Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish rooftop solar panels and solar panel canopies #101

Closed
1ec5 opened this issue Dec 22, 2020 · 4 comments
Closed

Distinguish rooftop solar panels and solar panel canopies #101

1ec5 opened this issue Dec 22, 2020 · 4 comments
Assignees
Milestone

Comments

@1ec5
Copy link
Contributor

1ec5 commented Dec 22, 2020

The Solar Panel preset should have a field or fields to distinguish a standalone solar panel from a rooftop solar panel (location=roof) or a solar panel that doubles as a canopy (building=roof), or perhaps there should even be separate presets for those configurations.

There are currently 27,334 solar panels tagged as canopies and 30,817 rooftop solar panels, out of 37,2 313 solar panel ways globally. Each of these solar panels would’ve been tagged manually, because the preset doesn’t offer building or roof-related fields. Anecdotally, I’ve come across plenty of solar panels that were undertagged so that a data consumer might mistake them for standalone units.

@quincylvania quincylvania self-assigned this Dec 23, 2020
@quincylvania quincylvania added this to the Next Release milestone Dec 23, 2020
@quincylvania
Copy link
Collaborator

@1ec5 Good idea, these will make for helpful presets.

iD doesn't currently have a field type where you can select between two tag values with different keys, but if we add that in the future then we could have a field for this.

@stragu
Copy link

stragu commented Jun 9, 2021

It's great news to have the new rooftop solar preset.

Is there any reason why I can't find it in the presets currently when using iD on openstreetmap.org? I thought it would have made it into version 2.19.6? Or is it because version 3.0.0 of the presets was packaged before commit 21e9158 ?

@1ec5
Copy link
Contributor Author

1ec5 commented Jun 12, 2021

Yes, it’s because that commit hasn’t made it into a release of id-tagging-schema yet. After that, iD would need to upgrade and be released, and the iD release would need to be deployed.

@stragu
Copy link

stragu commented Jun 13, 2021

thanks @1ec5 , I appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants