From ec2a8dd28ac0b965da74e257c2a81006e3ffbd83 Mon Sep 17 00:00:00 2001
From: Martin Raifer <martin@raifer.tech>
Date: Mon, 13 Feb 2023 20:58:57 +0100
Subject: [PATCH] hide "street_cabinet" field; add presets for special cabinets

after #777, unfortunately, there were two fields to define the sub-type of street cabinets: utility for the "common" ones (e.g. telecom, power, etc.) and the "legacy" street_cabinet field for the rest. This PR adds dedicated presets for the legacy cases where the "street_cabinet" tag is still to be used to solve this UI issue.
---
 data/presets/man_made/street_cabinet.json     |  4 +--
 .../street_cabinet/postal_service.json        | 27 +++++++++++++++++++
 .../street_cabinet/traffic_control.json       | 26 ++++++++++++++++++
 .../street_cabinet/traffic_monitoring.json    | 26 ++++++++++++++++++
 .../street_cabinet/transport_management.json  | 25 +++++++++++++++++
 .../man_made/street_cabinet/waste.json        | 22 +++++++++++++++
 6 files changed, 128 insertions(+), 2 deletions(-)
 create mode 100644 data/presets/man_made/street_cabinet/postal_service.json
 create mode 100644 data/presets/man_made/street_cabinet/traffic_control.json
 create mode 100644 data/presets/man_made/street_cabinet/traffic_monitoring.json
 create mode 100644 data/presets/man_made/street_cabinet/transport_management.json
 create mode 100644 data/presets/man_made/street_cabinet/waste.json

diff --git a/data/presets/man_made/street_cabinet.json b/data/presets/man_made/street_cabinet.json
index 1cce0287d..e828d97cc 100644
--- a/data/presets/man_made/street_cabinet.json
+++ b/data/presets/man_made/street_cabinet.json
@@ -7,13 +7,13 @@
     "fields": [
         "ref",
         "operator",
-        "street_cabinet",
         "utility_semi",
         "height",
         "colour"
     ],
     "moreFields": [
-        "model"
+        "model",
+        "street_cabinet"
     ],
     "terms": [
         "cable tv",
diff --git a/data/presets/man_made/street_cabinet/postal_service.json b/data/presets/man_made/street_cabinet/postal_service.json
new file mode 100644
index 000000000..20a3337ce
--- /dev/null
+++ b/data/presets/man_made/street_cabinet/postal_service.json
@@ -0,0 +1,27 @@
+{
+    "icon": "fas-door-closed",
+    "geometry": [
+        "point",
+        "area"
+    ],
+    "fields": [
+        "{man_made/street_cabinet}"
+    ],
+    "moreFields": [
+        "{man_made/street_cabinet}"
+    ],
+    "terms": [
+        "letter storage",
+        "post delivery",
+        "postal services"
+    ],
+    "tags": {
+        "man_made": "street_cabinet",
+        "street_cabinet": "postal_service"
+    },
+    "reference": {
+        "key": "street_cabinet",
+        "value": "postal_service"
+    },
+    "name": "Postal Relay Box"
+}
diff --git a/data/presets/man_made/street_cabinet/traffic_control.json b/data/presets/man_made/street_cabinet/traffic_control.json
new file mode 100644
index 000000000..c81f2b894
--- /dev/null
+++ b/data/presets/man_made/street_cabinet/traffic_control.json
@@ -0,0 +1,26 @@
+{
+    "icon": "fas-door-closed",
+    "geometry": [
+        "point",
+        "area"
+    ],
+    "fields": [
+        "{man_made/street_cabinet}"
+    ],
+    "moreFields": [
+        "{man_made/street_cabinet}"
+    ],
+    "terms": [
+        "traffic control automation",
+        "traffic light"
+    ],
+    "tags": {
+        "man_made": "street_cabinet",
+        "street_cabinet": "traffic_control"
+    },
+    "reference": {
+        "key": "man_made",
+        "value": "street_cabinet"
+    },
+    "name": "Traffic Controll System Cabinet"
+}
diff --git a/data/presets/man_made/street_cabinet/traffic_monitoring.json b/data/presets/man_made/street_cabinet/traffic_monitoring.json
new file mode 100644
index 000000000..ce772d2b2
--- /dev/null
+++ b/data/presets/man_made/street_cabinet/traffic_monitoring.json
@@ -0,0 +1,26 @@
+{
+    "icon": "fas-door-closed",
+    "geometry": [
+        "point",
+        "area"
+    ],
+    "fields": [
+        "{man_made/street_cabinet}"
+    ],
+    "moreFields": [
+        "{man_made/street_cabinet}"
+    ],
+    "terms": [
+        "traffic monitoring",
+        "vehicle counting"
+    ],
+    "tags": {
+        "man_made": "street_cabinet",
+        "street_cabinet": "traffic_monitoring"
+    },
+    "reference": {
+        "key": "man_made",
+        "value": "street_cabinet"
+    },
+    "name": "Traffic Monitoring Cabinet"
+}
diff --git a/data/presets/man_made/street_cabinet/transport_management.json b/data/presets/man_made/street_cabinet/transport_management.json
new file mode 100644
index 000000000..cca2d2d43
--- /dev/null
+++ b/data/presets/man_made/street_cabinet/transport_management.json
@@ -0,0 +1,25 @@
+{
+    "icon": "fas-door-closed",
+    "geometry": [
+        "point",
+        "area"
+    ],
+    "fields": [
+        "{man_made/street_cabinet}"
+    ],
+    "moreFields": [
+        "{man_made/street_cabinet}"
+    ],
+    "terms": [
+        "public transport automation"
+    ],
+    "tags": {
+        "man_made": "street_cabinet",
+        "street_cabinet": "transport_management"
+    },
+    "reference": {
+        "key": "man_made",
+        "value": "street_cabinet"
+    },
+    "name": "Transport Management Cabinet"
+}
diff --git a/data/presets/man_made/street_cabinet/waste.json b/data/presets/man_made/street_cabinet/waste.json
new file mode 100644
index 000000000..9effae468
--- /dev/null
+++ b/data/presets/man_made/street_cabinet/waste.json
@@ -0,0 +1,22 @@
+{
+    "icon": "maki-recycling",
+    "geometry": [
+        "point",
+        "area"
+    ],
+    "fields": [
+        "{man_made/street_cabinet}"
+    ],
+    "moreFields": [
+        "{man_made/street_cabinet}"
+    ],
+    "tags": {
+        "man_made": "street_cabinet",
+        "street_cabinet": "waste"
+    },
+    "reference": {
+        "key": "man_made",
+        "value": "street_cabinet"
+    },
+    "name": "Private Waste Collection Cabinet"
+}