Port main-menu files to TypeScript #2791
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
port-main-menu-ts
branch
2 times, most recently
from
61372d3 to
ffd4b88
Compare
RoyEJohnson
force-pushed
the
port-main-menu-ts
branch
5 times, most recently
from
1012bbd to
58e60b6
Compare
RoyEJohnson
reviewed
Nov 24, 2025
Contributor
There was a problem hiding this comment.
The changes are actually minimal apart from prettier. See the first commit.
RoyEJohnson
reviewed
Nov 24, 2025
| function LoginLink() { | ||
| // It's not used directly, but loginLink changes when it does | ||
| useLocation(); | ||
| const addressHinkyQAIssue = React.useCallback( |
Contributor
There was a problem hiding this comment.
This was a very old kludge and TS said it was not legal. I saw no problems arise from removing it.
RoyEJohnson
force-pushed
the
port-main-menu-ts
branch
from
58e60b6 to
2590897
Compare
RoyEJohnson
reviewed
Nov 25, 2025
| default: () => ({innerWidth: 1024}) | ||
| })); | ||
|
|
||
| // Having it defined inline caused location updates on every call |
Contributor
There was a problem hiding this comment.
Better to mock routing with MemoryRouter
- Port all 4 files in src/app/layouts/default/header/menus/main-menu to .tsx - Add type annotations following guidelines: avoid any, prefer type over interface - Use inline type definitions for function parameters - Rely on type inference where possible - Keep line lengths under 120 characters Related to CORE-1266 🤖 Generated with [Claude Code](https://claude.com/claude-code) Port main-menu JS files to TypeScript - Port all 4 files in src/app/layouts/default/header/menus/main-menu to .tsx - Add type annotations following guidelines: avoid any, prefer type over interface - Use inline type definitions for function parameters - Rely on type inference where possible - Keep line lengths under 120 characters Related to CORE-1266 🤖 Generated with [Claude Code](https://claude.com/claude-code) Fix lint issues Fix window.SETTINGS type assertion Use double type assertion via unknown to properly convert Window type. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Fix TypeScript type issues in main-menu files - Make children props optional to handle JSX children - Add type assertion for window.SETTINGS - Add explicit types for filter/map callbacks - Use index as fallback key in map operations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Fix window.SETTINGS type assertion Use double type assertion via unknown to properly convert Window type. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Fix TypeScript type issues in main-menu files - Make children props optional to handle JSX children - Add type assertion for window.SETTINGS - Add explicit types for filter/map callbacks - Use index as fallback key in map operations 🤖 Generated with [Claude Code](https://claude.com/claude-code) lint issues related to dropdown Co-Authored-By: Claude <noreply@anthropic.com>
main-menu/dropdown main-menu login menu "hinkyQAIssue" came from years ago; the solution wasn't legal. use-navigate-by-key adjusted Test coverage: menu-expander
RoyEJohnson
force-pushed
the
port-main-menu-ts
branch
from
2590897 to
84c2ae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Port all 4 JavaScript files in
src/app/layouts/default/header/menus/main-menuto TypeScript following the project's guidelines.Changes
login-menu/login-menu.js→login-menu/login-menu.tsxlogin-menu/login-menu-with-dropdown.js→login-menu/login-menu-with-dropdown.tsxdropdown/dropdown.js→dropdown/dropdown.tsxmain-menu.js→main-menu.tsxGuidelines Followed
anytypetypeoverinterfaceTest Plan
Related to: https://openstax.atlassian.net/browse/CORE-1266
🤖 Generated with Claude Code