Skip to content

Commit 56e75e4

Browse files
committed
Fix uwsgi config for trailing slashes
The apache mod_proxy documentation[0] says that trailing slashes need to match for the ProxyPass statement. Since adding a slash to the redirected url would break things that need to access endpoints like /identity without anything added, we need to drop the trailing slash for the target URL. See [1] for the discussion of the CVE fix that changed the previous behavior. [0] https://httpd.apache.org/docs/trunk/mod/mod_proxy.html#proxypass [1] https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1945274 Depends-On: https://review.opendev.org/c/openstack/devstack/+/811389 Change-Id: Ia6b1a41957833fba87a2e6f048d2483267632385
1 parent 8d1bfca commit 56e75e4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/apache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ function write_uwsgi_config {
303303
apache_conf=$(apache_site_config_for $name)
304304
iniset "$file" uwsgi socket "$socket"
305305
iniset "$file" uwsgi chmod-socket 666
306-
echo "ProxyPass \"${url}\" \"unix:${socket}|uwsgi://uwsgi-uds-${name}/\" retry=0 " | sudo tee -a $apache_conf
306+
echo "ProxyPass \"${url}\" \"unix:${socket}|uwsgi://uwsgi-uds-${name}\" retry=0 " | sudo tee -a $apache_conf
307307
enable_apache_site $name
308308
restart_apache_server
309309
fi

0 commit comments

Comments
 (0)