Skip to content

Commit 32c0089

Browse files
committed
Prepare for dropping keystone admin endpoint
Keystone no longer has any special functionality hidden behind the admin endpoint. Stop referencing it in consumers, so it can later be dropped completely. Change-Id: I04a5d77908005268cc7c59e7e9ddeea70f6732e2
1 parent 02da0c4 commit 32c0089

File tree

8 files changed

+11
-12
lines changed

8 files changed

+11
-12
lines changed

functions-common

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ KILL_PATH="$(which kill)"
4747

4848
# Save these variables to .stackenv
4949
STACK_ENV_VARS="BASE_SQL_CONN DATA_DIR DEST ENABLED_SERVICES HOST_IP \
50-
KEYSTONE_AUTH_URI KEYSTONE_SERVICE_URI \
50+
KEYSTONE_SERVICE_URI \
5151
LOGFILE OS_CACERT SERVICE_HOST STACK_USER TLS_IP \
5252
HOST_IPV6 SERVICE_IP_VERSION"
5353

lib/glance

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,7 @@ function configure_glance {
208208

209209
if is_service_enabled tls-proxy; then
210210
iniset $GLANCE_API_CONF DEFAULT bind_port $GLANCE_SERVICE_PORT_INT
211-
212-
iniset $GLANCE_API_CONF keystone_authtoken identity_uri $KEYSTONE_AUTH_URI
211+
iniset $GLANCE_API_CONF keystone_authtoken identity_uri $KEYSTONE_SERVICE_URI
213212
fi
214213

215214
# Format logging
@@ -221,7 +220,7 @@ function configure_glance {
221220
iniset $GLANCE_CACHE_CONF DEFAULT debug $ENABLE_DEBUG_LOG_LEVEL
222221
iniset $GLANCE_CACHE_CONF DEFAULT use_syslog $SYSLOG
223222
iniset $GLANCE_CACHE_CONF DEFAULT image_cache_dir $GLANCE_CACHE_DIR/
224-
iniset $GLANCE_CACHE_CONF DEFAULT auth_url $KEYSTONE_AUTH_URI
223+
iniset $GLANCE_CACHE_CONF DEFAULT auth_url $KEYSTONE_SERVICE_URI
225224
iniset $GLANCE_CACHE_CONF DEFAULT admin_tenant_name $SERVICE_PROJECT_NAME
226225
iniset $GLANCE_CACHE_CONF DEFAULT admin_user glance
227226
iniset $GLANCE_CACHE_CONF DEFAULT admin_password $SERVICE_PASSWORD

lib/keystone

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ KEYSTONE_SERVICE_URI=${KEYSTONE_SERVICE_PROTOCOL}://${KEYSTONE_SERVICE_HOST}/ide
115115
KEYSTONE_AUTH_URI=$KEYSTONE_SERVICE_URI
116116

117117
# V3 URIs
118-
KEYSTONE_AUTH_URI_V3=$KEYSTONE_AUTH_URI/v3
118+
KEYSTONE_AUTH_URI_V3=$KEYSTONE_SERVICE_URI/v3
119119
KEYSTONE_SERVICE_URI_V3=$KEYSTONE_SERVICE_URI/v3
120120

121121
# Security compliance
@@ -413,6 +413,7 @@ function configure_keystone_authtoken_middleware {
413413
local section=${3:-keystone_authtoken}
414414

415415
iniset $conf_file $section auth_type password
416+
iniset $conf_file $section interface public
416417
iniset $conf_file $section auth_url $KEYSTONE_SERVICE_URI
417418
iniset $conf_file $section username $admin_user
418419
iniset $conf_file $section password $SERVICE_PASSWORD
@@ -561,7 +562,6 @@ function stop_keystone {
561562
# - ``KEYSTONE_BIN_DIR``
562563
# - ``ADMIN_PASSWORD``
563564
# - ``IDENTITY_API_VERSION``
564-
# - ``KEYSTONE_AUTH_URI``
565565
# - ``REGION_NAME``
566566
# - ``KEYSTONE_SERVICE_PROTOCOL``
567567
# - ``KEYSTONE_SERVICE_HOST``

lib/neutron-legacy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ function configure_mutnauq {
372372
function create_nova_conf_neutron {
373373
local conf=${1:-$NOVA_CONF}
374374
iniset $conf neutron auth_type "password"
375-
iniset $conf neutron auth_url "$KEYSTONE_AUTH_URI"
375+
iniset $conf neutron auth_url "$KEYSTONE_SERVICE_URI"
376376
iniset $conf neutron username "$Q_ADMIN_USERNAME"
377377
iniset $conf neutron password "$SERVICE_PASSWORD"
378378
iniset $conf neutron user_domain_name "$SERVICE_DOMAIN_NAME"

lib/nova_plugins/hypervisor-ironic

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ function configure_nova_hypervisor {
4646
iniset $NOVA_CONF ironic auth_type password
4747
iniset $NOVA_CONF ironic username admin
4848
iniset $NOVA_CONF ironic password $ADMIN_PASSWORD
49-
iniset $NOVA_CONF ironic auth_url $KEYSTONE_AUTH_URI
49+
iniset $NOVA_CONF ironic auth_url $KEYSTONE_SERVICE_URI
5050
iniset $NOVA_CONF ironic project_domain_id default
5151
iniset $NOVA_CONF ironic user_domain_id default
5252
iniset $NOVA_CONF ironic project_name demo

lib/swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ function configure_swift {
527527
else
528528
iniset ${testfile} func_test auth_port 80
529529
fi
530-
iniset ${testfile} func_test auth_uri ${KEYSTONE_AUTH_URI}
530+
iniset ${testfile} func_test auth_uri ${KEYSTONE_SERVICE_URI}
531531
if [[ "$auth_vers" == "3" ]]; then
532532
iniset ${testfile} func_test auth_prefix /identity/v3/
533533
else

openrc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ export OS_AUTH_TYPE=password
8787

8888
# If you don't have a working .stackenv, this is the backup position
8989
KEYSTONE_BACKUP=$SERVICE_PROTOCOL://$SERVICE_HOST:5000
90-
KEYSTONE_AUTH_URI=${KEYSTONE_AUTH_URI:-$KEYSTONE_BACKUP}
90+
KEYSTONE_SERVICE_URI=${KEYSTONE_SERVICE_URI:-$KEYSTONE_BACKUP}
9191

92-
export OS_AUTH_URL=${OS_AUTH_URL:-$KEYSTONE_AUTH_URI}
92+
export OS_AUTH_URL=${OS_AUTH_URL:-$KEYSTONE_SERVICE_URI}
9393

9494
# Currently, in order to use openstackclient with Identity API v3,
9595
# we need to set the domain which the user and project belong to.

stack.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1053,7 +1053,7 @@ cat > $TOP_DIR/userrc_early <<EOF
10531053
10541054
# Set up password auth credentials now that Keystone is bootstrapped
10551055
export OS_IDENTITY_API_VERSION=3
1056-
export OS_AUTH_URL=$KEYSTONE_AUTH_URI
1056+
export OS_AUTH_URL=$KEYSTONE_SERVICE_URI
10571057
export OS_USERNAME=admin
10581058
export OS_USER_DOMAIN_ID=default
10591059
export OS_PASSWORD=$ADMIN_PASSWORD

0 commit comments

Comments
 (0)