Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run-perf.sh #208

Closed
wants to merge 1 commit into from
Closed

Add run-perf.sh #208

wants to merge 1 commit into from

Conversation

vdukhovni
Copy link

This is just the run-perf.sh script for sharing with the team, work-in-progress, do not merge.

@Sashan
Copy link
Contributor

Sashan commented Jun 25, 2024

I think this is good enough. I gave it try. to speed things up I've modified some parameters:

  • reduced number of iterations to two
  • reduced number of threads to 4 and 8
  • reduced versions to 1.1.1, 3.0, 3.3 and master

works flawlessly. I think it's good enough. I would not waste too much time with it. What we really need to decide are parmeters which we will be using for testing on all platforms:

  • number of iterations: the first version from @nhorman got 50, I've reduced the number to 25, but it still feels too much
  • versions I think @mattcaswell proposal to test 1.1.1, 3.0, 3.3 and master is sufficient
  • number of threads I like what @nhorman suggested: 1 2 4 8 16 32 64 128

with parameters like above we can expect test duration on ryzen 7 with 8 cores roughly 12 hours.

@t8m t8m requested a review from a team July 1, 2024 15:57
@nhorman nhorman changed the title WIP: stage improved run-perf.sh stage improved run-perf.sh Jul 1, 2024
Copy link
Contributor

@Sashan Sashan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's good enough to go in.

@vdukhovni
Copy link
Author

Applied a bit more polish and trimmed the version list. Left iterations and threads alone for now, pending future decisions. Should be good to merge.

@vdukhovni vdukhovni changed the title stage improved run-perf.sh Add run-perf.sh Jul 8, 2024
@nhorman
Copy link
Contributor

nhorman commented Aug 7, 2024

merged

@nhorman nhorman closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants