Add file locking tests for SEQUENTIAL, LINE-SEQUENTIAL, and RELATIVE files #710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive tests for file locking functionality for SEQUENTIAL, LINE-SEQUENTIAL, and RELATIVE file organizations to
tests/run.src/miscellaneous.at
.Changes Made
Test Coverage Added
Added 3 new test cases that verify file locking behavior:
PIC PP99
is wrong #110)Each test verifies all open modes work correctly:
OUTPUT
mode (file creation with shared lock)INPUT
mode (read access with exclusive lock)I-O
mode (read/write access with exclusive lock)EXTEND
mode (append access with exclusive lock)Implementation Analysis
Through code analysis, confirmed that file locking is already implemented for all three file types in the base
CobolFile
class:libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/file/CobolFile.java
open_(String filename, int mode, int sharing)
FileLock
withtryLock()
COB_STATUS_61_FILE_SHARING
) when file locking failsLock Behavior
Documentation
Added
doc/file-locking-implementation.md
documenting:The tests demonstrate that file locking functionality exists and works correctly for SEQUENTIAL, LINE-SEQUENTIAL, and RELATIVE files as requested.
Fixes #709.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.