New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shmem_wait_until_all[_vector] implementation looks wrong #11

Open

dalcinl opened this issue Oct 14, 2021 · 1 comment

dalcinl commented Oct 14, 2021 •

edited

Loading

I cannot make sense of the implementation of shmem_wait_until_all[_vector]().
https://github.com/openshmem-org/osss-ucx/blob/main/src/shmemc/ucx/waituntil.c#L221

if nelems > 0 and all entries of status are nonzero, then the routine it will loop forever and deadlock.
With only one of the ivars entries passing the test, eventually you will get n == nelems and the busy loop finishes.

The text was updated successfully, but these errors were encountered:

jdinan commented Oct 14, 2021

There is an erratum to OpenSHMEM 1.5 for this -- https://github.com/openshmem-org/specification/wiki/OpenSHMEM-1.5-Errata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment