Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

links to pipelines broken when username has special characters in it #575

Closed
maxandersen opened this issue Aug 15, 2017 · 8 comments
Closed

Comments

@maxandersen
Copy link
Collaborator

I have user manderse@redhat.com meaning my base url is https://openshift.io/manderse%40redhat.com but links in the Pipelines widget uses https://openshift.io/manderse/mirror3/create/pipelines as opposed to the correct url at https://openshift.io/manderse%40redhat.com/mirror3/create/pipelines

@ldimaggi
Copy link
Collaborator

We saw this once before.

See; fabric8-ui/fabric8-ui#1562

Is the issue due to the OSIO username != the github username?

@maxandersen
Copy link
Collaborator Author

No I don't think this is the same issue nor related to osio username != github usernames.

Issue is that my user has a @ in the name (i.e. manderse@redhat.com) which should be encoded as %40 but for some reason the links to pipelines cuts off at this symbol instead.

@alexeykazakov
Copy link
Member

alexeykazakov commented Nov 20, 2017

I'm removing team/auth and area/auth. This is an issue with pipeline UI. Not Auth.

@qodfathr
Copy link
Collaborator

@maxandersen is this bug still valid?

@maxandersen
Copy link
Collaborator Author

yes, still not fixed.

@andrewazores
Copy link
Collaborator

@qodfathr I think this has been resolved with the PRs for #1048 and #2334 - when working in those areas I didn't see any issue relating to special characters in particular, simply mishandling of usernames vs namespaces.

@qodfathr
Copy link
Collaborator

qodfathr commented Mar 1, 2018

@maxandersen care to verify if fixed?

@maxandersen
Copy link
Collaborator Author

missed this update - but yes its actually fixed now!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants