Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

Planner functional tests are failing #4654

Open
sanketpathak opened this issue Dec 19, 2018 · 2 comments
Open

Planner functional tests are failing #4654

sanketpathak opened this issue Dec 19, 2018 · 2 comments

Comments

@sanketpathak
Copy link
Collaborator

sanketpathak commented Dec 19, 2018

Issue Overview

Planner functional tests are failing at Prod and Prod-preview

Expected Behaviour

Tests should pass

Current Behaviour

Tests are failing

Steps To Reproduce
  1. Open E2E tests for Planner on prod at https://ci.centos.org/job/devtools-test-e2e-openshift.io-planner-functional-tests/921/console and on prod-preview at https://ci.centos.org/job/devtools-test-e2e-prod-preview.openshift.io-planner-functional-tests/3598/console
Additional Information

My guess goes to Mono repo Pr for planner in fabric-ui is responsible for this .

@sahil143 @divyanshiGupta please look into this.

@christianvogt
Copy link
Collaborator

These tests look to have been failing before the monorepo change.

Are these functional tests those found in the planner repo? If that's the case we need to make sure we now run the tests from the monorepo and ensure devs can run these there. We moved the code and got unit tests working but we never tried functional tests. I brought this up in the UI sync.

We also need to figure out how best to run these functional tests on PR deliveries as right now we only run unit tests and e2e tests.

@rgarg1
Copy link
Collaborator

rgarg1 commented Dec 20, 2018

@christianvogt Planner UI tests were always running against all Planner PRs. Now that we've a new monorepo, all those jobs need to be updated. @sahil143 and @divyanshiGupta manage the Planner UI tests now so they can look into it. This should be a priority task IMHO.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants