Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

Dynamic fields lose unsaved values on work item update #3951

Open
rgarg1 opened this issue Jul 11, 2018 · 23 comments
Open

Dynamic fields lose unsaved values on work item update #3951

rgarg1 opened this issue Jul 11, 2018 · 23 comments

Comments

@rgarg1
Copy link
Collaborator

rgarg1 commented Jul 11, 2018

A question for the UX team....

Consider the following scenario:

  1. User open work item quick preview
  2. Enters some value on a dynamic field like Story points. Doesn't saves the value yet
  3. Edits the iteration of the work item. This causes the work item to reload and the storypoints entered earlier by the user are lost.

So, is it okay to lose data in the dynamic fields on an update, or the data must be retained is the question.

@rgarg1
Copy link
Collaborator Author

rgarg1 commented Jul 11, 2018

Cc @Veethika @divyanshiGupta

@kwk
Copy link
Contributor

kwk commented Jul 11, 2018

@rgarg1

So, is it okay to lose data in the dynamic fields on an update, or the data must be retained is the question.

It is absolutely NOT okay to discard the entered data!

@Veethika
Copy link

@rgarg1 if the user has edited any field in the quick preview panel and has not committed to it or saved it, the moment they perform an action that calls for the closing of the panel, a warning should appear asking them to commit to the change or discard it.

@rgarg1 rgarg1 changed the title Should dynamic fields retain values on work item update? Dynamic fields lose unsaved values on work item update Jul 13, 2018
@rgarg1
Copy link
Collaborator Author

rgarg1 commented Jul 13, 2018

Thanks @Veethika and @kwk for your suggestions.

Given the inputs, this becomes a defect in Planner UI.

@muruGanesan
Copy link
Collaborator

muruGanesan commented Jul 17, 2018

@rgarg1, I believe this issue is closed or addressed from the UX side. If yes, you can remove UX labels.

@Veethika, @AshishDurgude, @sunilmalagi, @sdash-redhat, would you like to capture this UX recommendation as part of UX standards in our design wiki?

@rgarg1
Copy link
Collaborator Author

rgarg1 commented Jul 17, 2018

Done @muruGanesan

@muruGanesan
Copy link
Collaborator

thanks @rgarg1

@joshuawilson
Copy link
Member

This is still an issue.

@kwk kwk added priority/P2 High and removed priority/P3 Medium labels Nov 2, 2018
@kwk
Copy link
Contributor

kwk commented Nov 2, 2018

I consider this a high priority because of Data loss.

@nimishamukherjee
Copy link
Collaborator

a warning should appear asking them to commit to the change or discard it.

@openshiftio/uxd-team please provide a visual of the warning.
cc @Veethika @sunilmalagi

@joshuawilson
Copy link
Member

I don't think we need a warning as much as auto-save. When you leave the field it should save the information.

@rgarg1
Copy link
Collaborator Author

rgarg1 commented Nov 13, 2018

+1 to @joshuawilson

@nimishamukherjee
Copy link
Collaborator

I don't think we need a warning as much as auto-save. When you leave the field it should save the information.

@Veethika @serenamarie125 please comment ^^

@divyanshiGupta
Copy link
Collaborator

@Veethika is the UX ready for this?

@joshuawilson
Copy link
Member

@divyanshiGupta for now, you can just auto-save it. That is the normal use of a form.

@divyanshiGupta
Copy link
Collaborator

@joshuawilson okay 👍

@christianvogt
Copy link
Collaborator

christianvogt commented Dec 18, 2018

@Veethika if we implement auto save, do you still want to have an ok button along side the cancel? In this case now the ok button does the same as navigating away. Will users expect that their input is saved if they don't press ok? Maybe they enter a value and think it will be discarded if they don't press ok and are surprised it gets saved.

@christianvogt
Copy link
Collaborator

Btw I think the original issue was that editing a separate field causes data lose in an unsaved field. This is indeed a bug. The user should have the ability to go back to the first field and save or discard the value. Instead the value was thrown away unexpectedly. It had nothing to do with closing the panel.

@divyanshiGupta divyanshiGupta self-assigned this Dec 19, 2018
@Veethika
Copy link

Btw I think the original issue was that editing a separate field causes data to lose in an unsaved field. This is indeed a bug. The user should have the ability to go back to the first field and save or discard the value. Instead, the value was thrown away unexpectedly. It had nothing to do with closing the panel.

@christianvogt Right, my solution swayed towards the opening and closing the panel which should be addressed in a different story altogether. For this issue, the work-item should not be reloaded everytime a user begins to edit a field.
But the state of the fields has to be maintained for a 'session' if I'm not wrong. So are we referring to end of the session as 'until another work item is selected'(the content of quick preview changes)?

@christianvogt
Copy link
Collaborator

@Veethika @joshuawilson
I believe this issue is exactly the same as I logged here: #4643

What we do if the user chooses to navigate away is a separate issue. But when editing the same issue, we are losing data. If we fix this problem, do we still need an auto save? Or a warning about navigating away?

@joshuawilson
Copy link
Member

@christianvogt can you close #4643 as a duplicate?

@divyanshiGupta
Copy link
Collaborator

What we do if the user chooses to navigate away is a separate issue. But when editing the same issue, we are losing data. If we fix this problem, do we still need an auto save? Or a warning about navigating away?

@Veethika what is the suggested UX?

@divyanshiGupta divyanshiGupta changed the title Dynamic fields lose unsaved values on work item update [6]Dynamic fields lose unsaved values on work item update Jan 16, 2019
@divyanshiGupta divyanshiGupta changed the title [6]Dynamic fields lose unsaved values on work item update Dynamic fields lose unsaved values on work item update Jan 16, 2019
@divyanshiGupta
Copy link
Collaborator

Unassigning myself as I am not working on this issue currently as I have some other tasks on priority.

@divyanshiGupta divyanshiGupta removed their assignment Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.