Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

API restrictions on characters allowed in space names should govern characters accepted in UI #3503

Open
rgarg1 opened this issue May 8, 2018 · 11 comments

Comments

@rgarg1
Copy link
Collaborator

rgarg1 commented May 8, 2018

  1. Log into OSIO
  2. Browse to the page to see all your spaces
  3. Try deleting a space. Observe that space is not deleted and you see a 500 error response from the backend API
@rgarg1
Copy link
Collaborator Author

rgarg1 commented May 8, 2018

Priority @qodfathr ?

Cc @maxandersen @kwk

@kwk
Copy link
Contributor

kwk commented May 8, 2018

I can confirm the issue but interestingly the space disappears from the list of my spaces anyways.

@joshuawilson
Copy link
Member

Is this a refresh issue? or does not delete it all?

@alexeykazakov
Copy link
Member

Maybe related to #3580

@ldimaggi
Copy link
Collaborator

See: #3580

The error is due to the spaces including characters that the UI prevents the users from including in space names.

@rgarg1 To confirm - try this with a space (name) that is created in the UI.

@aptmac
Copy link
Collaborator

aptmac commented May 22, 2018

When deleting a space, is the expectation that all of it's data should disappear? I'm not quite sure the act of deleting a space is actually deleting it. When creating a new space the console prints out the updated spaces object, and mine contains a bunch of old "deleted" spaces that I had made for testing a while ago.

Example:

I currently only have 4 spaces as seen on the 'My Spaces' page:
myspaces

When I create a new space, the console logs the updated spaces object. It still has record of all the work spaces that I created (and deleted).
console1

I actually had so much text in that object that the console asked me if I wanted to view the next 25,000 characters.
console2

@ldimaggi
Copy link
Collaborator

Ruchir - just confirm - what is the syntax of the name of the spaces that you cannot delete?

@joshuawilson joshuawilson added this to the Platform Backlog milestone May 29, 2018
@rgarg1
Copy link
Collaborator Author

rgarg1 commented May 30, 2018

@ldimaggi Yes, I can confirm that spaces created with a : in the name have this problem. Though the UI enforces not to have a ':' in the space name, the same is allowed through the API.

@rgarg1 rgarg1 changed the title Cannot delete spaces. "500 Internal Server Error" from the API Cannot delete spaces having names with disallowed characters. Such spaces could be created via API May 30, 2018
@ldimaggi ldimaggi changed the title Cannot delete spaces having names with disallowed characters. Such spaces could be created via API API restrictions on characters allowed in space names should govern characters accepted in UI May 30, 2018
@ldimaggi
Copy link
Collaborator

API restrictions on characters allowed in space names should govern characters accepted in UI

The issue here is that at present, the UI is more restrictive than the API. The best approach would be for the API to define the set of allowed characters, and have the UI stay in synch with those restrictions.

@rgarg1
Copy link
Collaborator Author

rgarg1 commented Jun 1, 2018

Due to this issue, I'm stuck with piles of test spaces created using API. Reset env is of no help either:
unable to erase spaces

@joshuawilson
Copy link
Member

@aslakknutsen who can fix this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants