Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

Add a button to close the popup #3066

Open
xcoulon opened this issue Apr 12, 2018 · 14 comments
Open

Add a button to close the popup #3066

xcoulon opened this issue Apr 12, 2018 · 14 comments

Comments

@xcoulon
Copy link
Collaborator

xcoulon commented Apr 12, 2018

When changing the state of a work item, I get a popup to confirm that the change was taken into account, but I have to wait for a few seconds for it to disappear automatically, which is annoying, especially because this popup is partially over the button to close the work item panel:

screenshot 2018-04-12 16 13 34

@catrobson
Copy link
Collaborator

We should not display a toast notification for every work item update. Toast notifications should be reserved for more serious actions such as Creation and Deletion. Editing parts of a work item should not need to show a toast notification.

@Preeticp
Copy link
Collaborator

Currently these notifications are displayed even when you do not actually update the work item. For instance, you click the assignee field, and decide not to add any assignee, you still get a 'workitem updated' notice.

@GeorgeActon
Copy link
Collaborator

This notification is more than a minor problem. If you are updating multiple work items ypu have a built in 4/5 second delay every time you do an update and want to go to the next item.

Work around: It took me awhile to realize that if I had the expanded list view, I could just click on the next item without closing the current item and update the next one.

This wold indicate to me that the notification serves no purpose and should be removed.

@joshuawilson
Copy link
Member

The ESC key also gets you out of the side panel view.

@nimishamukherjee
Copy link
Collaborator

@sunilmalagi please confirm the behaviour for notifications when a work item is updated.
Can we go ahead with @catrobson 's suggestion?

@sunilmalagi
Copy link
Collaborator

@nimishamukherjee Agree with Catherine's suggestion. Lets have notifications for only bigger actions which is creation of new work item's and not for minor changes and edits on any quick previews.

@catrobson catrobson removed the team/ux label Apr 15, 2018
@rgarg1
Copy link
Collaborator

rgarg1 commented Apr 25, 2018

@sunilmalagi Are we also agreeing on providing a close option to dismiss the notification, if the users need to?

@rgarg1
Copy link
Collaborator

rgarg1 commented Apr 25, 2018

Even though its marked as SEV-3, it is such an irritant that I'd rather see it bumped to SEV-2 + priority0.

WDYT @qodfathr ?

@qodfathr
Copy link
Collaborator

@rgarg1 I agree it's super annoying, but I feel the severity is currently correct. Even if we bumped to SEV2, I would not assign p0.

But, if all of the Planner SEV2 p0's get completed, then I'd vote to move this to SEV2 and put it at the top of the stack. :)

@Veethika
Copy link

@xcoulon @Preeticp @rgarg1 @nimishamukherjee We should go ahead with @catrobson 's suggestion of showing notification only for serious actions and not when there's a very clear visual feedback following it.
And every notification should come with a 'close' option to avoid any hinderance.
Let me know if we all agree on this so that @sunilmalagi could take it further.

@Veethika
Copy link

Veethika commented Oct 4, 2018

UX solution provided, un-assigning myself.

@Veethika Veethika closed this as completed Oct 4, 2018
@Veethika Veethika reopened this Oct 4, 2018
@Veethika
Copy link

Veethika commented Oct 8, 2018

@rgarg1 @xcoulon removing UX label from this issue as the solution has been provided and awaits implementation.

@Veethika Veethika removed the area/UX label Oct 8, 2018
@nimishamukherjee
Copy link
Collaborator

nimishamukherjee commented Nov 21, 2018

We now have notifications only for errors.

@christianvogt
Copy link
Collaborator

As per UX guidance, our notifications should include a close button.

@Veethika Veethika removed their assignment Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests