Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

Wrong link to Jenkins on GH status icon #1259

Open
bartoszmajsak opened this issue Nov 1, 2017 · 11 comments
Open

Wrong link to Jenkins on GH status icon #1259

bartoszmajsak opened this issue Nov 1, 2017 · 11 comments

Comments

@bartoszmajsak
Copy link
Contributor

bartoszmajsak commented Nov 1, 2017

After creating new quickstart in OSIO I see build status icon GH commit. It reflects real state (build is pending as it needs approval), but clicking on it gets me to http://unconfigured-jenkins-location/job/bartoszmajsak/job/bartosz-sdp-test-01/job/master/2/display/redirect.

image

Repo: https://github.com/bartoszmajsak/bartosz-sdp-test-01

@bartoszmajsak bartoszmajsak changed the title Build status on initial GH commit in Pending state Wrong link to jenkins on GH status icon Nov 1, 2017
@bartoszmajsak bartoszmajsak changed the title Wrong link to jenkins on GH status icon Wrong link to Jenkins on GH status icon Nov 1, 2017
@bartoszmajsak
Copy link
Contributor Author

Out of curiosity - why the commit says openshift-io committed with jboss ? Where is this jboss thingy coming from?

$ git show
commit 99588e832d7f4d76decb84a9d8507f2a14bb7d65 (HEAD -> master, origin/master, origin/HEAD)
Author: bartoszmajsak <openshiftio@redhat.com>
Date:   Wed Nov 1 09:21:31 2017 +0000

    Initial import

@kbsingh
Copy link
Collaborator

kbsingh commented Nov 24, 2017

unsure how the service-delivery team can help here ? removing tag, but let us know if there is anything we can help with . this looks to be a cicd team / forge area problem.

also moving from analytics to new-app to reflect ownership

@bartoszmajsak
Copy link
Contributor Author

Obviously, the same problem occurs on PR checks, as status API from GH is related to any commits, including merge commits which are shown in PR status.

Bumping it to SEV2 as this should be in my opinion fixed rather urgently. cc @chmouel @lordofthejars

@bartoszmajsak
Copy link
Contributor Author

Duplicate: #2504

@sthaha
Copy link
Collaborator

sthaha commented Mar 11, 2018

Steps to reproduce

  1. create quickstart project
  2. create a pull-request to the project on GitHub
  3. wait for the CI to trigger
  4. Look at the Details link see: ci-run-link

Expected

Must point to actual jenkins job console

Actual

Points to http://unconfigured-jenkins-location/job/{user}/job/{repo}/job/{branch}/1/display/redirect

@chmouel
Copy link

chmouel commented Mar 12, 2018

I add this to our backlog on https://github.com/orgs/fabric8io/projects/2

@sthaha
Copy link
Collaborator

sthaha commented Jun 20, 2018

This would only be solved as a part of CICD.next as link to jenkins.openshift.io can only route to the jenkins of the logged in user.

Perhaps we should close this as won't fix

/cc @krishnapaparaju @pradeepto

@chmouel
Copy link

chmouel commented Jul 19, 2018

Issue reported here by @gabemontero here https://issues.jenkins-ci.org/browse/JENKINS-48079

we need to reopen this @sthaha this is a jenkins image issue, the problem is actually that we don't have a proper jenkins.model.JenkinsLocationConfiguration.xml in $JENKINS_HOME

I have just done this with the right URL, for example :

<?xml version='1.0' encoding='UTF-8'?>
<jenkins.model.JenkinsLocationConfiguration>
  <jenkinsUrl>https://jenkins-cboudjna-osiotest1-jenkins.b542.starter-us-east-2a.openshiftapps.com/</jenkinsUrl>
</jenkins.model.JenkinsLocationConfiguration>

and I have it reporting properly the URL :

image

Since there is a bug what about we set this up at boot time in jenkins script boot ? We have all the info we want there to get it

@sthaha
Copy link
Collaborator

sthaha commented Jul 30, 2018

@bartoszmajsak
Copy link
Contributor Author

@sthaha wassup with this one? :)

@sthaha
Copy link
Collaborator

sthaha commented Aug 13, 2018

@bartoszmajsak that has been filed as a feature-request in Planner see the planner link

Supporting this requires changes to the way proxy handles requests. Currently jenkins.openshift.io forwards requests to their jenkins instance. So if I submit a PR to your project just publishing the link to jenkins.openshift.io/jobs/repo/pr-/ won't help as it will try to take me to my jenkins (if available) instead of yours.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants