Update to v0.8.0 #7
Conversation
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
PR prometheus#318 forgot to wire parseCPUInfo to parseCPUInfoRISCV on GOARCH=riscv{,64}, leading to a build/test failure: ./cpuinfo.go:71:9: undefined: parseCPUInfo ./cpuinfo_test.go:222:2: undefined: parseCPUInfo Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
…theus#339) * Fix for mountstats error due to multiline "impl_id" on FreeNAS This commit fixes an error happening when trying to parse data from FreeNAS NFS mount point. "impl_id" is printed in multiple lines, which triggers "not enough information for NFS stats" error. Signed-off-by: Jakub Wesolowski <jakubwesolowski@posteo.net>
Linux limits are uint64, not int64[0]. "unlimited" is also defined as max uint64. [0]: https://github.com/torvalds/linux/blob/7c53f6b671f4aba70ff15e1b05148b10d58c2837/include/uapi/linux/resource.h#L48-L53 Signed-off-by: Brandon Bell <bbell@invoca.com>
This patch adds support for extracting system socket metrics found only in /proc/net/protocols. The most interesting metrics found here are per-protocol socket counts along with the total memory in pages used by each. For TCP connections this data can be used to tune/monitor a system against the thresholds set in net.ipv4.tcp_mem. This file also exposes a pressure metric which indicates whether or not a protocol like TCP has entered memory pressure, which again is useful in troubleshooting things like memory pressure induced packet drops on loopback. Some additional albeit less interesting metrics that come out of this file include the size of each protocol's struct, and the maximum header size the kernel is willing to allocate. The additional columns enumerate capabilities per-protocol and are encoded as bools. Signed-off-by: Juan Bran <juan.bran@verizondigitalmedia.com>
Signed-off-by: Wisniewski, Krzysztof2 <Krzysztof2.Wisniewski@intel.com>
This commit includes: 1. MDStat struct extention to hold raid component devices. 2. A util funciton that extracts raid component devices from /proc/mdstat info. 3. UTs adjustments. 4. codespell exceptions adjsutments - add to ignored list the word "hda" which appears in UTs as a compoent device. Signed-off-by: Shimon Turjeman <shimon@lightbitslabs.com>
According to the table in https://xfs.org/index.php/Runtime_Stats, the first number of `rw` stats is write and the second is read. I noticed Prometheus seemed to be reporting the opposite of what I expected. Signed-off-by: William Starling <william@bugsnag.com>
…nfo (prometheus#331) Signed-off-by: binjip978 <binjip978@gmail.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Signed-off-by: Vitaliy Filippov <vitalif@yourcmc.ru> Co-authored-by: Vitaliy Filippov <vitalif@yourcmc.ru>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Signed-off-by: Evan Lezar <evanlezar@gmail.com>
* Add GIDs to ProcStatus struct
Signed-off-by: Andrei Volnin <wolandr@gmail.com>
* support to read from /proc/net/tcp{,6}
Signed-off-by: Hubert Chen <hubert@branchmetrics.io>
Co-authored-by: Andrei Volnin <wolandr@gmail.com>
* fix crash seen in node_exporter Signed-off-by: Hubert Chen <hubert@branchmetrics.io>
This patch adds support for reading slab info from /proc/slabinfo. For more info see man 5 slabinfo. Signed-off-by: Daniel Hodges <hodges.daniel.scott@gmail.com>
Include `err` in some error returns to allow `error.Is()` to work. Signed-off-by: Ben Kochie <superq@gmail.com>
Use Go 1.13 `%w` error formatting
* Update minimum Go version to 1.13.
* Bump vendoring.
* Update all error format strings to use %w.
* Cleanup consistency of use.
* Cleanup use of `errors.New("string" + var)` to use `fmt.Errorf()`.
prometheus#310
Signed-off-by: Ben Kochie <superq@gmail.com>
Update error message handling
Fix parsing of infiniband rate for unconnected/unpopulated ports. Fixes: prometheus#361 Signed-off-by: Ben Kochie <superq@gmail.com>
Fix infiniband rate parsing
Signed-off-by: Robert Fratto <robertfratto@gmail.com>
Signed-off-by: Robert Fratto <robertfratto@gmail.com>
The sysfs contains some useful information about NVMe devices that should be exporter by the Prometheus node exporter. Add a `NVMeClass` function to collect the information for the node exporter. See: prometheus/node_exporter#1891 Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
…freebsd Mark sysfs as Linux-only
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Signed-off-by: MashaSamoylova <mashanedyak@gmail.com>
Counters added: * excessive_buffer_overrun_errors * local_link_integrity_errors Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Add several Infiniband counters
Ignore missing files in bcache metrics. * cache_readahead was removed in Kernel Version 5.13: https://lkml.org/lkml/2021/5/31/1602 Fixes: prometheus#445 Signed-off-by: Josh Niec <ironick09@gmail.com>
This change fixes a potential source of panic when the status line in mdstat is empty and the code is trying to reference first item in a zero-sized slice. Signed-off-by: Artur Makutunowicz <arma@linkedin.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
This prevents the test fixtures from being shipped around in the module cache. ie. Prior if project A has a dependency on this project then running `go mod vendor` will pull the fixtures.ttar into the vendor folder Signed-off-by: dprotaso <dprotaso@gmail.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
* Update minimum supported version to 1.17. * Update Go modules. * Enable dependabot. Signed-off-by: SuperQ <superq@gmail.com>
Go 1.16 deprecated several `io/ioutil` functions. * `ioutil.ReadFile` -> `os.ReadFile` * `ioutil.ReadAll` -> `io.ReadAll` * `ioutil.ReadDir` -> `os.ReadDir` Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: anguswilliams <anguswilliams@gmail.com>
Signed-off-by: Johannes Ziemke <github@5pi.de>
Signed-off-by: Johannes Ziemke <github@5pi.de>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raptorsun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@raptorsun: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold we would need a downstream version of prometheus/procfs only if openshift/node_exporter depended on it but it isn't the case apparently https://github.com/openshift/node_exporter/blob/af2f49cac92d4ec56fd495c0ecfc0e0a4149eea5/go.mod#L25 |
openshift-ci
bot
added
the
do-not-merge/hold
ok, we leave this aside. Node Exporter uses github.com/prometheus/procfs directly. |
|
it also looks like we never used it? Should we get rid of this fork then? |
|
We used it a while ago (> 2 years probably) because we had to carry a downstream patch and didn't want to have a go.mod replace directive in github.com/openshift/node_exporter pointing to github.com/(individual_contributor)/procfs. |
|
I'm experimenting with another option which is to carry the dependency patch directly in the downstream repository that needs it: |
|
/close This PR is closed because it is unnecessary now. |
|
@raptorsun: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
20 participants
Align the master branch to upstream tag v0.8.0