Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-48820: OLMv1: Add additional context on failure #29410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-48820: OLMv1: Add additional context on failure #29410

wants to merge 1 commit into from
+15 −4

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jan 8, 2025

Also, use a wildcard (3.x) for the quay-operator version.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 8, 2025
@openshift-ci-robot
Copy link

@tmshort: This pull request references Jira Issue OCPBUGS-46516, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Also, use a wildcard (3.x) for the quay-operator version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 8, 2025
@openshift-ci openshift-ci bot requested review from anik120 and kevinrizza January 8, 2025 21:02
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Jan 8, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 8, 2025
@openshift-ci-robot
Copy link

@tmshort: This pull request references Jira Issue OCPBUGS-46516, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from Xia-Zhao-rh January 8, 2025 21:02
@tmshort
Copy link
Contributor Author

tmshort commented Jan 9, 2025

/test e2e-gcp-ovn

@grokspawn
Copy link

/retest

camilamacedo86
camilamacedo86 reviewed Jan 21, 2025
View reviewed changes
test/extended/olm/olmv1.go
@@ -169,10 +177,11 @@ var _ = g.Describe("[sig-olmv1][OCPFeatureGate:NewOLM][Skipped:Disconnected] OLM

const (
packageName = "quay-operator"
version = "3.13.0"
version = "3.x"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the version?

Copy link

@camilamacedo86 camilamacedo86 Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the description it is intentional

OK

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
camilamacedo86
camilamacedo86 approved these changes Jan 21, 2025
View reviewed changes
Copy link

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@grokspawn
Copy link

/retest

@tmshort
Copy link
Contributor Author

tmshort commented Jan 21, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 21, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a87dfc8 and 2 for PR HEAD 3f92dfb in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a87dfc8 and 2 for PR HEAD 3f92dfb in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 618ea1c and 1 for PR HEAD 3f92dfb in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4b05413 and 0 for PR HEAD 3f92dfb in total

This was referenced Jan 22, 2025
Merged
Merged
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4b05413 and 2 for PR HEAD 3f92dfb in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4ca8255 and 2 for PR HEAD 3f92dfb in total

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Jan 23, 2025

Job Failure Risk Analysis for sha: 3f92dfb

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Medium
[sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial]
This test has passed 96.36% of 412 runs on release 4.19 [Overall] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-serial Medium
[sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial]
This test has passed 96.36% of 412 runs on release 4.19 [Overall] in the last week.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a30e8f6 and 2 for PR HEAD 3f92dfb in total

@tmshort tmshort force-pushed the add-olm-failure-context branch from 3f92dfb to 827d685 Compare January 23, 2025 18:51
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@tmshort tmshort changed the title OCPBUGS-46516: OLMv1: Add additional context on failure OCPBUGS-48820: OLMv1: Add additional context on failure Jan 23, 2025
@openshift-ci-robot
Copy link

@tmshort: This pull request references Jira Issue OCPBUGS-48820, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Also, use a wildcard (3.x) for the quay-operator version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Contributor Author

tmshort commented Jan 23, 2025

/jira refresh

@openshift-ci-robot
Copy link

@tmshort: This pull request references Jira Issue OCPBUGS-48820, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Contributor Author

tmshort commented Jan 23, 2025

Moved to a different bug, since this is a different set of code change from OCPBUGS-46516

@tmshort tmshort force-pushed the add-olm-failure-context branch from 827d685 to e668f3d Compare January 24, 2025 15:58
@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Jan 24, 2025

Job Failure Risk Analysis for sha: e668f3d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-fips Medium
[sig-olmv1][OCPFeatureGate:NewOLM][Skipped:Disconnected] OLMv1 operator installation should block cluster upgrades if an incompatible operator is installed [Suite:openshift/conformance/parallel]
This test has passed 97.06% of 102 runs on jobs [periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-fips] in the last 14 days.

Open Bugs
Component Readiness: [Unknown] [Other] test regressed
---
[sig-olmv1][OCPFeatureGate:NewOLM][Skipped:Disconnected] OLMv1 operator installation should install a cluster extension [Suite:openshift/conformance/parallel]
This test has passed 97.76% of 134 runs on jobs [periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-fips] in the last 14 days.

Open Bugs
Component Readiness: [Unknown] [Other] test regressed
Component Readiness: [Unknown] [Other] test regressed
Component Readiness: [Unknown] [Other] test regressed

@tmshort
OCPBUGS-46516: OLMv1: Add additional context on failure
0b0b516 
Also, use a wildcard (3.x) for the quay-operator version.

Signed-off-by: Todd Short <todd.short@me.com>
@tmshort tmshort force-pushed the add-olm-failure-context branch from e668f3d to 0b0b516 Compare January 29, 2025 15:01
LalatenduMohanty
LalatenduMohanty approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, LalatenduMohanty, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort
Copy link
Contributor Author

tmshort commented Jan 29, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 12, 2025

@tmshort: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 0b0b516 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-ovn-ipv6 0b0b516 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-ovn 0b0b516 link true /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-upi 0b0b516 link true /test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@anik120 anik120 Awaiting requested review from anik120

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

@Xia-Zhao-rh Xia-Zhao-rh Awaiting requested review from Xia-Zhao-rh

Assignees

@LalatenduMohanty LalatenduMohanty

@camilamacedo86 camilamacedo86

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tmshort @openshift-ci-robot @grokspawn @LalatenduMohanty @camilamacedo86