Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration of ResourceGroup in Azure StorageClass #20268

Closed
wants to merge 4 commits into from
Closed

Allow configuration of ResourceGroup in Azure StorageClass #20268

wants to merge 4 commits into from

Conversation

jsafrane
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added sig/storage size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2018
@wongma7
Copy link
Contributor

wongma7 commented Jul 10, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2018
@gnufied
Copy link
Member

gnufied commented Jul 10, 2018

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gnufied, jsafrane, wongma7
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@childsb
Copy link
Contributor

childsb commented Jul 24, 2018

/assign @smarterclayton

@jsafrane
Copy link
Contributor Author

/retest

1 similar comment
@jsafrane
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

@jsafrane: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/gcp 6556e91 link /test gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor Author

/assign @mfojtik
for approval

@openshift-bot
Copy link
Contributor

@jsafrane: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2018
@jsafrane
Copy link
Contributor Author

It seems that the patch went in in the last Kubernetes rebase

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootfs rootfs Awaiting requested review from rootfs

@sttts sttts Awaiting requested review from sttts

Assignees

@gnufied gnufied

@mfojtik mfojtik

@smarterclayton smarterclayton

@wongma7 wongma7

Labels
lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/storage size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jsafrane @wongma7 @gnufied @openshift-ci-robot @childsb @openshift-bot @mfojtik @smarterclayton