[3.10] Allow configuration of ResourceGroup in Azure StorageClass #20130
Conversation
openshift-ci-robot
added
sig/storage
size/M
|
Is resource group available anywhere in pv/pvc after provisioning? Will it be needed for delete or something else? |
|
Reading Azure docs, a resource group must be created by admin before setting up the storage class. And it's up to the admin to remove it. |
|
/retest |
|
Closing in favor of https://github.com/openshift/ose/pull/1340 |
|
/reopen for merge |
|
/lgtm |
|
/assign @smarterclayton @mfojtik |
|
@knobunc can you approve? |
|
/approve |
|
/lgtm Over to you @smarterclayton |
|
/approve
…On Tue, Aug 21, 2018 at 3:50 PM OpenShift CI Robot ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *childsb
<#20130 (comment)>*, *jsafrane
<#20130#>*, *knobunc
<#20130 (comment)>*, *wongma7
<#20130 (comment)>*
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: *mfojtik*
If they are not already assigned, you can assign the PR to them by writing /assign
@mfojtik in a comment when ready.
The full list of commands accepted by this bot can be found here
<https://go.k8s.io/bot-commands>.
The pull request process is described here
<https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process>
Needs approval from an approver in each of these files:
- *vendor/k8s.io/kubernetes/pkg/OWNERS
<https://github.com/openshift/origin/blob/release-3.10/vendor/k8s.io/kubernetes/pkg/OWNERS>*
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20130 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pzI9GAPuiJ5GpAhcU6D_tkZl1Dddks5uTGRtgaJpZM4U7mq1>
.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: childsb, jsafrane, knobunc, smarterclayton, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1596319
Contains these PRs:
@openshift/sig-storage, PTAL