Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.10] Fix default image paths used in network diagnostics #20116

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #20013

/assign pravisankar

 - In case of OCP, generated defaults for 3.10 release:
   --pod-image=registry.access.redhat.com/openshift3/ose-control-plane:v3.10
   --test-pod-image=registry.access.redhat.com/openshift3/ose-deployer:v3.10

 - In case of origin, generated defaults for 3.10 release:
   --pod-image=openshift/origin-control-plane:v3.10
   --test-pod-image=openshift/origin-deployer:v3.10

 - For testing on AWS, user need to manually pass the image params
   --pod-image=registry.reg-aws.openshift.com:443/openshift3/ose-control-plane:v3.10
   --test-pod-image=docker.io/openshift/hello-openshift
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 27, 2018
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2018
@knobunc
Copy link
Contributor

knobunc commented Jun 27, 2018

/retest

1 similar comment
@knobunc
Copy link
Contributor

knobunc commented Jun 27, 2018

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9453255 into openshift:release-3.10 Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants