Skip to content

Fix example certificates used in router tests #17959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deads2k merged 1 commit into from
Jan 3, 2018
Merged

Fix example certificates used in router tests #17959

deads2k merged 1 commit into from
Jan 3, 2018

Conversation

@mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Jan 2, 2018

seems like go 1.8 is strict on requiring EOL in certs https://golang.org/doc/go1.8#encoding_pem

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 2, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 2, 2018
@mfojtik
Copy link
Contributor Author

mfojtik commented Jan 2, 2018

cc @liggitt

@deads2k
Copy link
Contributor

deads2k commented Jan 2, 2018

weird, but lgtm.

@mfojtik
Copy link
Contributor Author

mfojtik commented Jan 2, 2018

/cherrypick release-3.8

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 2, 2018

@mfojtik: once the present PR merges, I will cherry-pick it on top of release-3.8 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik changed the title wip: test fixing router certificates Fix example certificates used in router tests Jan 2, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2018
soltysh
soltysh approved these changes Jan 3, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor

soltysh commented Jan 3, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jan 3, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@mfojtik mfojtik added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. queue/critical-fix labels Jan 3, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2018 •
edited
Loading

@mfojtik: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/cmd 26868a4 link /test cmd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Jan 3, 2018

Was green and in queue. Unblocks other pulls. Scoped to test fixes. Merging

@deads2k deads2k merged commit c350213 into openshift:release-3.7 Jan 3, 2018
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 3, 2018
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 3, 2018

@mfojtik: new pull request created: #17966

Details

In response to this:

/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik deleted the test-certs branch September 5, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xmichalis 0xmichalis Awaiting requested review from 0xmichalis

@liggitt liggitt Awaiting requested review from liggitt

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. queue/critical-fix size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mfojtik @deads2k @openshift-cherrypick-robot @openshift-ci-robot @soltysh @openshift-merge-robot