-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 51473: Fix cAdvisor prometheus metrics #16048
Merged
openshift-merge-robot
merged 1 commit into
openshift:master
from
smarterclayton:cadvisor_fix
Sep 1, 2017
Merged
UPSTREAM: 51473: Fix cAdvisor prometheus metrics #16048
openshift-merge-robot
merged 1 commit into
openshift:master
from
smarterclayton:cadvisor_fix
Sep 1, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Aug 29, 2017
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Aug 29, 2017
Verified locally that it fixes the issue.
…On Tue, Aug 29, 2017 at 7:51 PM, OpenShift Merge Robot < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *APPROVED*
This pull-request has been approved by: *smarterclayton
<#16048#>*
The full list of commands accepted by this bot can be found here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
Needs approval from an approver in each of these OWNERS Files:
- vendor/k8s.io/kubernetes/pkg/kubelet/OWNERS
<https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/kubelet/OWNERS>
[smarterclayton]
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#16048 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p94xqmHqflvP4tM9XudJBKhuCTorks5sdKQAgaJpZM4PGsWV>
.
|
/assign @sjenning |
openshift-merge-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
and removed
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Aug 30, 2017
smarterclayton
added
lgtm
Indicates that a PR is ready to be merged.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
and removed
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Aug 31, 2017
marking to unblock cm-ops |
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15974
@sjenning