Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can edit a build config to a strategy that isn't allowed by policy - builds still fail correctly #6556

Closed
jwforres opened this issue Jan 6, 2016 · 1 comment · Fixed by #6576
Assignees
Labels
component/build kind/bug Categorizes issue or PR as related to a bug. priority/P1

Comments

@jwforres
Copy link
Member

jwforres commented Jan 6, 2016

If I apply the policy changes to restrict certain build strategies, I can create a BC with an allowed strategy and then edit the BC to use a restricted strategy, that edit should fail. Instead it allows the modification. It does still correctly prevent the builds from being launched.

@csrwng
Copy link
Contributor

csrwng commented Jan 13, 2016

@bparees or @jwforres can you change the priority of this issue to P1? It allows escalating privileges on a node. You don't need to explicitly be able to create a build once you've created a build config with a forbidden type. An image change trigger can do that for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build kind/bug Categorizes issue or PR as related to a bug. priority/P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants