DeplymentController uses an unusual construct for getByKey

[soltysh]

I found this

origin/pkg/deploy/controller/deployer/factory.go

Lines 219 to 222 in 0c81307

	if errors.IsNotFound(err) {
	glog.V(4).Infof("Replication controller %q has been deleted", key)
	return nil, nil
	}

which I had to fix in image controller in #15927.

I'm guessing @tnozicka you'll be the best person to address the same issue in deployments. Generally getByKey should not interpret errors.

[tnozicka]

Yes, that seems ugly. Not sure if that is a bug since it's a private function so as long as the deployer controller checks for it properly, should work; although it's error prone.

[soltysh]

although it's error prone.

That's why you need to fix it. I did the same in images.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[soltysh]

/remove-lifecycle stale
/lifecycle frozen