Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment lifecycle hooks should have ownerRef to deployer pod #14592

Open
mfojtik opened this issue Jun 12, 2017 · 2 comments
Open

Deployment lifecycle hooks should have ownerRef to deployer pod #14592

mfojtik opened this issue Jun 12, 2017 · 2 comments
Labels
area/reliability component/apps lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/P2

Comments

@mfojtik
Copy link
Contributor

mfojtik commented Jun 12, 2017

When you delete the running deployer pod, the pre/post hook will keep running forever. The lifecycle hook pods should have ownerRef set to the deployer pod and be tied to the lifecycle of the deployer pod (as that pod controls them).

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2018
@tnozicka
Copy link
Contributor

/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 12, 2018
@tnozicka tnozicka removed their assignment Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/reliability component/apps lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/P2
Projects
None yet
Development

No branches or pull requests

4 participants