Wizard fixes for iPhone #2451
Merged
Wizard fixes for iPhone #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
spadgett
force-pushed
the
mobile-overlay-scroll
branch
2 times, most recently
from
d4be115 to
c23d8f7
Compare
openshift-ci-robot
added
size/L
spadgett
force-pushed
the
mobile-overlay-scroll
branch
from
c23d8f7 to
b49544b
Compare
spadgett
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/kind bug Largely whitespace changes. |
openshift-ci-robot
added
the
kind/bug
jwforres
approved these changes
Nov 3, 2017
|
/lgtm |
|
/hold typo in one rule |
openshift-ci-robot
added
the
do-not-merge/hold
* Prevent page scrolling under the wizard dialog, making it difficult to scroll the wizard content itself * Don't add custom scrollbar styles on iOS, which cause layout problems on an iPhone * Reduce wizard max-height on iPhone to prevent the buttons being hidden on iPhone X
spadgett
force-pushed
the
mobile-overlay-scroll
branch
from
b49544b to
0b72b1e
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
/retest |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2450
@rhamilto @jwforres