Skip to content

HCIDOCS-745: Indent bullets on postinstallation configuration. #95004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnwilkins
Copy link
Contributor

@johnwilkins johnwilkins commented Jun 19, 2025

Indented bullets properly. Incorporated vale comments. Edits only. No QE needed.

Fixes: HCIDOCS-745

See https://issues.redhat.com/browse/HCIDOCS-745 for additional details.

Preview URL: https://95004--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/index.html

For release(s): 4.16-4.19
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 19, 2025

@johnwilkins: This pull request references HCIDOCS-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Indented bullets properly. Incorporated vale comments.

Fixes: HCIDOCS-745

See https://issues.redhat.com/browse/HCIDOCS-745 for additional details.

Preview URL: http://jowilkin.com:8080/HCIDOCS-745/welcome/index.html

For release(s): 4.16-4.19
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 19, 2025

@johnwilkins: This pull request references HCIDOCS-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Indented bullets properly. Incorporated vale comments.

Fixes: HCIDOCS-745

See https://issues.redhat.com/browse/HCIDOCS-745 for additional details.

Preview URL: http://jowilkin.com:8080/HCIDOCS-745/welcome/index.html

For release(s): 4.16-4.19
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 19, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 19, 2025

🤖 Fri Jun 20 19:56:51 - Prow CI generated the docs preview:

https://95004--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/index.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 19, 2025

@johnwilkins: This pull request references HCIDOCS-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Indented bullets properly. Incorporated vale comments.

Fixes: HCIDOCS-745

See https://issues.redhat.com/browse/HCIDOCS-745 for additional details.

Preview URL: https://95004--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/index.html

For release(s): 4.16-4.19
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 19, 2025

@johnwilkins: This pull request references HCIDOCS-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

In response to this:

Indented bullets properly. Incorporated vale comments. Edits only. No QE needed.

Fixes: HCIDOCS-745

See https://issues.redhat.com/browse/HCIDOCS-745 for additional details.

Preview URL: https://95004--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/index.html

For release(s): 4.16-4.19
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@johnwilkins
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 19, 2025
@eromanova97
Copy link
Contributor

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 20, 2025
Copy link
Contributor

@eromanova97 eromanova97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have added just one small suggestion outside of scope to consider.
Thank you!

/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 20, 2025
Copy link

openshift-ci bot commented Jun 20, 2025

@johnwilkins: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@johnwilkins
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants