-
Notifications
You must be signed in to change notification settings - Fork 1.8k
HCIDOCS-745: Indent bullets on postinstallation configuration. #95004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@johnwilkins: This pull request references HCIDOCS-745 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
@johnwilkins: This pull request references HCIDOCS-745 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Fri Jun 20 19:56:51 - Prow CI generated the docs preview: |
@johnwilkins: This pull request references HCIDOCS-745 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@johnwilkins: This pull request references HCIDOCS-745 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label peer-review-needed |
/remove-label peer-review-needed /label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I have added just one small suggestion outside of scope to consider.
Thank you!
/remove-label peer-review-in-progress
/label peer-review-done
@johnwilkins: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
Indented bullets properly. Incorporated vale comments. Edits only. No QE needed.
Fixes: HCIDOCS-745
See https://issues.redhat.com/browse/HCIDOCS-745 for additional details.
Preview URL: https://95004--ocpdocs-pr.netlify.app/openshift-enterprise/latest/post_installation_configuration/index.html
For release(s): 4.16-4.19
QE Review:
Signed-off-by: John Wilkins jowilkin@redhat.com