[OCPBUGS-62642] Fix amIAdmin function to correctly check admin group membership #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
needs-rebase
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Add exemption for the osd-admin user when it has the cluster-admins group to support OpenShift CI e2e tests. This is a targeted exemption that requires both the specific username AND group membership. Security rationale: - In production OSD clusters, customers cannot arbitrarily assign users to the cluster-admins group as it's managed by the OAuth infrastructure - The exemption only applies when BOTH conditions are met: username is osd-admin AND user is in cluster-admins group - This is more restrictive than the previous blanket cluster-admins group exemption that was removed in SREP-1565 This fixes CI test failures in openshift/origin endpoint admission tests where the osd-admin user needs to create privileged namespaces like kube-system for testing purposes.
dustman9000
force-pushed
the
allow-endpoint-controller-namespace-access
branch
from
b5ea847 to
59ae773
Compare
openshift-merge-robot
removed
the
needs-rebase
Member
Author
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Contributor
|
@dustman9000: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow osd-admin user with cluster-admins group for e2e tests
Add exemption for the osd-admin user when it has the cluster-admins group
to support OpenShift CI e2e tests. This is a targeted exemption that requires
both the specific username AND group membership.
Security rationale:
the cluster-admins group as it's managed by the OAuth infrastructure
osd-admin AND user is in cluster-admins group
exemption that was removed in SREP-1565
This fixes CI test failures in openshift/origin endpoint admission tests
where the osd-admin user needs to create privileged namespaces like
kube-system for testing purposes.