-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-30266: fix: introduce minimum allocation sizes #603
OCPBUGS-30266: fix: introduce minimum allocation sizes #603
Conversation
Signed-off-by: Jakob Möller <jmoller@redhat.com>
Skipping CI for Draft Pull Request. |
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-30266, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test all |
/override ci/prow/snyk-deps |
@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/snyk-deps In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
/test unit-test |
/override ci/prow/snyk-deps |
@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/snyk-deps In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, jeff-roche The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-30266, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jakobmoellerdev: An error was encountered updating to the MODIFIED state for bug OCPBUGS-30266 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Get "https://issues.redhat.com/rest/api/2/issue/OCPBUGS-30266/transitions?expand=transitions.fields": GET https://issues.redhat.com/rest/api/2/issue/OCPBUGS-30266/transitions?expand=transitions.fields giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@jakobmoellerdev: Jira Issue OCPBUGS-30266: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-30266 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This introduces minimum allocation sizing on the topolvm controller server equivalent to our upstream. The difference here is that we set our own limits so that we can later transition to a more dynamic configuration if required. For now the minimum limits should suffice.