NO-JIRA: feat: add sort func for controller errors #1916
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@eggfoobar: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
eggfoobar
force-pushed
the
sort-errors-config-observer
branch
from
0e2db5e to
7800329
Compare
added sort func to help make testing easy by having a consistent output for a list of errors Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
sort-errors-config-observer
branch
from
7800329 to
7ed1617
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, dusk125, eggfoobar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@eggfoobar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
added sort func to help make testing easy by having a consistent output for a list of errors