Merge pull request kubernetes-sigs#1656 from slashpai/fix-wire-flags

chore: remove feature flags unsupported

Author: k8s-ci-robot

cmd/metrics-server/app/options/options.go

@@ -27,6 +27,7 @@ import (
 	"k8s.io/client-go/rest"
 	"k8s.io/client-go/tools/clientcmd"
 	"k8s.io/component-base/cli/flag"
+	"k8s.io/component-base/compatibility"
 	"k8s.io/component-base/logs"
 	logsapi "k8s.io/component-base/logs/api/v1"
 	_ "k8s.io/component-base/logs/json/register"
@@ -100,7 +101,7 @@ func (o *Options) Flags() (fs flag.NamedFlagSets) {
 // NewOptions constructs a new set of default options for metrics-server.
 func NewOptions() *Options {
 	return &Options{
-		GenericServerRunOptions: genericoptions.NewServerRunOptions(),
+		GenericServerRunOptions: genericoptions.NewServerRunOptionsForComponent("metrics server", compatibility.NewComponentGlobalsRegistry()),
 		SecureServing:           genericoptions.NewSecureServingOptions().WithLoopback(),
 		Authentication:          genericoptions.NewDelegatingAuthenticationOptions(),
 		Authorization:           genericoptions.NewDelegatingAuthorizationOptions(),

docs/command-line-flags.txt

@@ -16,39 +16,13 @@ Generic flags:
       --emulated-version strings                           The versions different components emulate their capabilities (APIs, features, ...) of.
                                                            If set, the component will emulate the behavior of this version instead of the underlying binary version.
                                                            Version format could only be major.minor, for example: '--emulated-version=wardle=1.2,kube=1.31'.
-                                                           Options are: kube=1.31..1.33(default:1.33)
+                                                           Options are:
                                                            If the component is not specified, defaults to "kube"
       --emulation-forward-compatible                       If true, for any beta+ APIs enabled by default or by --runtime-config at the emulation version, their future versions with higher priority/stability will be auto enabled even if they introduced after the emulation version. Can only be set to true if the emulation version is lower than the binary version.
       --external-hostname string                           The hostname to use when generating externalized URLs for this master (e.g. Swagger API Docs or OpenID Discovery).
       --feature-gates colonSeparatedMultimapStringString   Comma-separated list of component:key=value pairs that describe feature gates for alpha/experimental features of different components.
                                                            If the component is not specified, defaults to "kube". This flag can be repeatedly invoked. For example: --feature-gates 'wardle:featureA=true,wardle:featureB=false' --feature-gates 'kube:featureC=true'Options are:
-                                                           kube:APIResponseCompression=true|false (BETA - default=true)
-                                                           kube:APIServerIdentity=true|false (BETA - default=true)
-                                                           kube:APIServerTracing=true|false (BETA - default=true)
-                                                           kube:APIServingWithRoutine=true|false (ALPHA - default=false)
-                                                           kube:AllAlpha=true|false (ALPHA - default=false)
-                                                           kube:AllBeta=true|false (BETA - default=false)
-                                                           kube:AllowParsingUserUIDFromCertAuth=true|false (BETA - default=true)
-                                                           kube:AllowUnsafeMalformedObjectDeletion=true|false (ALPHA - default=false)
-                                                           kube:AnonymousAuthConfigurableEndpoints=true|false (BETA - default=true)
-                                                           kube:AuthorizeWithSelectors=true|false (BETA - default=true)
-                                                           kube:CBORServingAndStorage=true|false (ALPHA - default=false)
-                                                           kube:ConcurrentWatchObjectDecode=true|false (BETA - default=false)
-                                                           kube:ConsistentListFromCache=true|false (BETA - default=true)
-                                                           kube:CoordinatedLeaderElection=true|false (BETA - default=false)
-                                                           kube:ListFromCacheSnapshot=true|false (ALPHA - default=false)
-                                                           kube:MutatingAdmissionPolicy=true|false (ALPHA - default=false)
-                                                           kube:OpenAPIEnums=true|false (BETA - default=true)
-                                                           kube:RemoteRequestHeaderUID=true|false (BETA - default=true)
-                                                           kube:ResilientWatchCacheInitialization=true|false (BETA - default=true)
-                                                           kube:StorageVersionAPI=true|false (ALPHA - default=false)
-                                                           kube:StorageVersionHash=true|false (BETA - default=true)
-                                                           kube:StreamingCollectionEncodingToJSON=true|false (BETA - default=true)
-                                                           kube:StreamingCollectionEncodingToProtobuf=true|false (BETA - default=true)
-                                                           kube:StructuredAuthenticationConfiguration=true|false (BETA - default=true)
-                                                           kube:UnauthenticatedHTTP2DOSMitigation=true|false (BETA - default=true)
-                                                           kube:WatchCacheInitializationPostStartHook=true|false (BETA - default=false)
-                                                           kube:WatchList=true|false (BETA - default=false)
+
       --goaway-chance float                                To prevent HTTP/2 clients from getting stuck on a single apiserver, randomly close a connection (GOAWAY). The client's other in-flight requests won't be affected, and the client will reconnect, likely landing on a different apiserver after going through the load balancer again. This argument sets the fraction of requests that will be sent a GOAWAY. Clusters with single apiservers, or which don't use a load balancer, should NOT enable this. Min is 0 (off), Max is .02 (1/50 requests); .001 (1/1000) is a recommended starting point.
       --livez-grace-period duration                        This option represents the maximum amount of time it should take for apiserver to complete its startup sequence and become live. From apiserver's start time to when this amount of time has elapsed, /livez will assume that unfinished post-start hooks will complete successfully and therefore return true.
       --max-mutating-requests-inflight int                 This and --max-requests-inflight are summed to determine the server's total concurrency limit (which must be positive) if --enable-priority-and-fairness is true. Otherwise, this flag limits the maximum number of mutating requests in flight, or a zero value disables the limit completely. (default 200)