Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-33496: ensure ipv6 bootstrap VM client-id is predictable #8480

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-33496: ensure ipv6 bootstrap VM client-id is predictable #8480

wants to merge 1 commit into from

Conversation

mkowalski
Copy link
Contributor

In #5110 we hade sure that for Baremetal IPI the IPv6 bootstrap VM client-id is predictable. This however did not cover UPI deployments.

With this change deployments with platform none will also use predictable client-id.

Fixes: OCPBUGS-33496

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 27, 2024
@openshift-ci-robot
Copy link
Contributor

@mkowalski: This pull request references Jira Issue OCPBUGS-33496, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In #5110 we hade sure that for Baremetal IPI the IPv6 bootstrap VM client-id is predictable. This however did not cover UPI deployments.

With this change deployments with platform none will also use predictable client-id.

Fixes: OCPBUGS-33496

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mkowalski
Copy link
Contributor Author

/cc @cybertron

@openshift-ci openshift-ci bot requested review from cybertron, rna-afk and rwsu May 27, 2024 15:53
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkowalski
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 27, 2024
@openshift-ci-robot
Copy link
Contributor

@mkowalski: This pull request references Jira Issue OCPBUGS-33496, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 27, 2024
@openshift-ci openshift-ci bot requested a review from gpei May 27, 2024 15:55
cybertron
cybertron reviewed May 28, 2024
View reviewed changes
data/data/bootstrap/none/files/etc/NetworkManager/conf.d/99-ipv6.conf Outdated
@@ -0,0 +1,5 @@
[main]
rc-manager=unmanaged
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want this. It will break any platform that doesn't use resolv-prepender.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, removing. I was partially blind as why we have it so just copy-pasted

@mkowalski
OCPBUGS-33496: ensure ipv6 bootstrap VM client-id is predictable
058619d 
In openshift#5110 we hade sure that
for Baremetal IPI the IPv6 bootstrap VM client-id is predictable. This
however did not cover UPI deployments.

With this change deployments with platform `none` will also use
predictable client-id.

Fixes: OCPBUGS-33496
@cybertron
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
@mkowalski
Copy link
Contributor Author

/retest-required

@mkowalski
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 058619d link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-images 058619d link true /test okd-images
ci/prow/e2e-azure-ovn-upi 058619d link true /test e2e-azure-ovn-upi
ci/prow/e2e-gcp-ovn-upi 058619d link true /test e2e-gcp-ovn-upi
ci/prow/e2e-azure-ovn-resourcegroup 058619d link false /test e2e-azure-ovn-resourcegroup
ci/prow/e2e-openstack-ovn 058619d link true /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cybertron cybertron cybertron left review comments

@rna-afk rna-afk Awaiting requested review from rna-afk

@rwsu rwsu Awaiting requested review from rwsu

@gpei gpei Awaiting requested review from gpei

Assignees

@cybertron cybertron

Labels
jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkowalski @openshift-ci-robot @cybertron