Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-25482: Adding PER check for BYO workspace on PowerVS #7841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

miyamotoh
Copy link
Contributor

@miyamotoh miyamotoh commented Dec 14, 2023

When a user brings his/her own PowerVS Workspace for deploy, we need to check if it's got PER enabled before proceeding. So, a little additional logic in validation.go along with a couple more test cases.

Signed-off-by: Hiro Miyamoto miyamotoh@us.ibm.com

Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2023
Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miyamotoh miyamotoh changed the title WIP: Adding PER check for BYO workspace on PowerVS OCPBUGS-25482: Adding PER check for BYO workspace on PowerVS Dec 19, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 19, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 19, 2023
@openshift-ci-robot
Copy link
Contributor

@miyamotoh: This pull request references Jira Issue OCPBUGS-25482, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Signed-off-by: Hiro Miyamoto miyamotoh@us.ibm.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjturek
Copy link
Contributor

mjturek commented Dec 20, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@mjturek: This pull request references Jira Issue OCPBUGS-25482, which is invalid:

  • expected the bug to target only the "4.16.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjturek
Copy link
Contributor

mjturek commented Dec 20, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@mjturek: This pull request references Jira Issue OCPBUGS-25482, which is invalid:

  • expected the bug to target only the "4.16.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjturek
Copy link
Contributor

mjturek commented Dec 20, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 20, 2023
@openshift-ci-robot
Copy link
Contributor

@mjturek: This pull request references Jira Issue OCPBUGS-25482, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gpei December 20, 2023 16:50
@mjturek
Copy link
Contributor

mjturek commented Dec 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@miyamotoh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-openstack-capi-manifests 9081e84 link true /test altinfra-openstack-capi-manifests
ci/prow/altinfra-periodics-images 9081e84 link true /test altinfra-periodics-images
ci/prow/agent-integration-tests 9081e84 link true /test agent-integration-tests
ci/prow/gofmt 9081e84 link true /test gofmt
ci/prow/okd-scos-images 9081e84 link true /test okd-scos-images
ci/prow/openstack-manifests 9081e84 link true /test openstack-manifests
ci/prow/e2e-azure-ovn-upi 9081e84 link true /test e2e-azure-ovn-upi
ci/prow/e2e-aws-ovn-upi 9081e84 link true /test e2e-aws-ovn-upi
ci/prow/e2e-aws-ovn-edge-zones-manifest-validation 9081e84 link true /test e2e-aws-ovn-edge-zones-manifest-validation
ci/prow/golint 9081e84 link true /test golint
ci/prow/e2e-vsphere-ovn 9081e84 link true /test e2e-vsphere-ovn
ci/prow/integration-tests 9081e84 link true /test integration-tests
ci/prow/e2e-metal-ipi-ovn-ipv6 9081e84 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-ovn-upi 9081e84 link true /test e2e-vsphere-ovn-upi
ci/prow/unit 9081e84 link true /test unit
ci/prow/e2e-gcp-ovn-upi 9081e84 link true /test e2e-gcp-ovn-upi
ci/prow/e2e-openstack-ovn 9081e84 link true /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn 9081e84 link true /test e2e-gcp-ovn
ci/prow/altinfra-images 9081e84 link true /test altinfra-images
ci/prow/verify-vendor 9081e84 link true /test verify-vendor
ci/prow/integration-tests-nodejoiner 9081e84 link true /test integration-tests-nodejoiner
ci/prow/e2e-azure-ovn 9081e84 link true /test e2e-azure-ovn
ci/prow/e2e-aws-ovn 9081e84 link true /test e2e-aws-ovn
ci/prow/verify-codegen 9081e84 link true /test verify-codegen
ci/prow/artifacts-images 9081e84 link true /test artifacts-images
ci/prow/e2e-agent-compact-ipv4 9081e84 link true /test e2e-agent-compact-ipv4
ci/prow/govet 9081e84 link true /test govet

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants