-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/user/aws/install_upi: Explain DNS-zone lookup #2420
Merged
openshift-merge-robot
merged 1 commit into
openshift:master
from
wking:aws-dns-shared-private-zone
Oct 14, 2019
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK ingress-operator adds the dns records to for
clusterdomain
only. Can it handle any other?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ingress is filling
DNSRecord
requests. In most cases now this is just going to be thedefault-wildcard
record, and I dropped an example YAML dump of that into the 14e0691 commit message for the curious ;). But folks pushing newDNSRecord
s will probably get them filled, because I don't think the ingress operator has (or should have) guards about whichDNSRecord
s it should or should not fill. If you're authorized to push aDNSRecord
where ingress is looking, you should get it filled.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in case where the private dns zone id is for
not-clusterdomain.
then the DNSRecord created by default would fail right.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, probably. Although it depends on the zone domains. So you could have an
example.com
zone, and Ingress could create ana.example.com
record even if your cluster wasc.d.e.example.com
(I think ;). But yeah, I expect it would fail to createexample.edu
. Does that matter? We aren't telling them to createDNSRecord
s here, we're just telling them how to feed zones to the ingress operator, which can have its own docs about what it can and cannot support.