docs/user/aws/images: Dia source for UPI arch diagram #1525
Conversation
openshift-ci-robot
added
size/XL
| all: install_upi.svg install_upi_vpc.svg | ||
|
|
||
| install_upi.svg: install_upi.dia AWS-Architecture-Icons_SVG/.touch AWS-Architecture-Icons_SVG/Light-BG/_Group\ Icons/Security-group_light-bg.svg | ||
| dia --export $@ $< |
There was a problem hiding this comment.
do you think will be worth it to add a note somewhere to say dia is a pre-req which can be installed using OS pkg tools - brew, apt, yum, dnf etc
There was a problem hiding this comment.
do you think will be worth it to add a note somewhere to say
diais a pre-req which can be installed using OS pkg tools - brew, apt, yum, dnf etc
Won't folks without it get a useful "command not found" error already? And I'd be surprised if all that many people were bumping the .dia source. So I'm currently leaning towards "punt". But I'd be fine landing docs if someone else wrote them up and they looked like they wouldn't go stale quickly ;).
There was a problem hiding this comment.
happy to add some notes (but will be in a week time once i'm back online)
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
removed
the
do-not-merge/hold
| @@ -0,0 +1,20 @@ | |||
| all: install_upi.svg install_upi_vpc.svg | |||
There was a problem hiding this comment.
can we document how to build it / or a small script rather than add make for consistency?
There was a problem hiding this comment.
can we document how to build it / or a small script rather than add make for consistency?
We could, but it's going to take more space than the Makefile (e.g. we'd have to write our own code or text about checking for a pre-existing icon zip, unpacking the zip, etc. I don't expect a huge contributor base feeding diagram changes (although I guess you never know), so I'm ok with it how it stands, but am also happy to add docs (CONTRIBUTING.md? docs/user/aws/images/README.md? A Makefile header comment?) that say:
To rebuild the
*.svg, runmakein this directory.
|
I've pushed f5ee4a584 -> ed55423b9, adding |
Dia is from Stephen Cuppett, replacing the PNG he'd submitted via 39a926a (Adding initial user doc/guide & materials for UPI AWS installation, 2019-03-12, openshift#1408). We aren't using the full file with all the layers yet, but I'm building it anyway because folks without Dia may still want to look at it ;). SVGs generated with: $ dia --version Dia version 0.97.3, compiled 18:02:21 Feb 11 2017 relink-dia.py embeds the referenced icons in the SVG with def and use [1,2] to avoid icon URIs like: file:///.../openshift/installer/docs/user/aws/images/./AWS-Architecture-Icons_SVG/Light-BG/_General%20AWS/AWS-General_AWS-Cloud_light-bg.svg Ideally Dia would have a way to do this sort of thing automatically with a command-line switch, but if it does, I can't find it. [1]: https://developer.mozilla.org/en-US/docs/Web/SVG/Element/def [2]: https://developer.mozilla.org/en-US/docs/Web/SVG/Element/use
|
I've waited long enough for the namespace to get reaped: $ oc delete project ci-op-40fyf45z
Error from server (Forbidden): projects.project.openshift.io "ci-op-40fyf45z" is forbidden: User "wking" cannot delete projects.project.openshift.io in the namespace "ci-op-40fyf45z": no RBAC policy matched/retest |
|
@wking @abhinavdahiya I have an update to the DIA file for private masters ready to go, can this get LGTM and then I'll open a PR to update it? |
|
/assign @abhinavdahiya |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Dia is from @cuppett, replacing the PNG he'd submitted via 39a926a (#1408).
We aren't using the full file with all the layers yet, but I'm building it anyway because folks without Dia may still want to look at it ;).