Skip to content

MCO-1533: Update MachineConfigNode Enhancement #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Mar 11, 2025

This updates the MCN enhancement to describe the functionality as it stands in 4.19. Some of the major changes included are:

  • Changes made to the MCN API resources & the introduction of a v1 API
  • Updates made to MCN functionality since this enhancement's last update
  • General cleanup/clarification/spelling corrections, etc.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 11, 2025

@isabella-janssen: This pull request references MCO-1533 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2025
Copy link
Contributor

openshift-ci bot commented Mar 11, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign frobware for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 31, 2025

@isabella-janssen: This pull request references MCO-1533 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This updates the MCN enhancement with:

  • Changes made to the API for GA
  • Updates that were made to MCN functionality since this enhancement's last update
  • General cleanup/clarification/spelling corrections, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2025
@openshift-bot
Copy link

Stale enhancement proposals rot after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Rotten proposals close after an additional 7d of inactivity.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 9, 2025
@openshift-bot
Copy link

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this May 17, 2025
Copy link
Contributor

openshift-ci bot commented May 17, 2025

@openshift-bot: Closed this PR.

In response to this:

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@isabella-janssen
Copy link
Member Author

/reopen

@openshift-ci openshift-ci bot reopened this May 22, 2025
Copy link
Contributor

openshift-ci bot commented May 22, 2025

@isabella-janssen: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2025

@isabella-janssen: This pull request references MCO-1533 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This updates the MCN enhancement with:

  • Changes made to the API for GA
  • Updates that were made to MCN functionality since this enhancement's last update
  • General cleanup/clarification/spelling corrections, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member Author

/remove-lifecycle stale

@isabella-janssen
Copy link
Member Author

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 22, 2025
@isabella-janssen isabella-janssen marked this pull request as ready for review May 22, 2025 19:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2025
@openshift-ci openshift-ci bot requested review from Prashanth684 and tkashem May 22, 2025 19:08
@isabella-janssen isabella-janssen force-pushed the mcn-updates branch 2 times, most recently from 16309d5 to e1c1108 Compare May 29, 2025 13:46
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 29, 2025

@isabella-janssen: This pull request references MCO-1533 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This updates the MCN enhancement with:

  • Changes made to the MCN API resources for GA
  • Updates that were made to MCN functionality since this enhancement's last update
  • General cleanup/clarification/spelling corrections, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2025

@isabella-janssen: This pull request references MCO-1533 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This updates the MCN enhancement to describe the functionality as it stands in 4.19. Some of the major changes included are:

  • Changes made to the MCN API resources & the introduction of a v1 API
  • Updates made to MCN functionality since this enhancement's last update
  • General cleanup/clarification/spelling corrections, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

@isabella-janssen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


### Non-Goals

* Modify or remove existing API and status fields
* Modify or remove existing API and status fields.
* MCN will not be a feature for Hypershift. See [this Slack thread](https://redhat-internal.slack.com/archives/CE4L0F143/p1745431032849839?thread_ts=1744910197.447789&cid=CE4L0F143) for more details.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While having the reasons of why MCN is out of scope for Hypershift I think that pointing to Slack is not a proper solution for two reasons:

  1. Enhancements are public but our internal Slack is not. A non-redhater may want to have that context too.
  2. The thread has a mix of conversations and only a fraction of it is telling the reason of why MCN is not supported in Hypershift.

I'd recommend to add a brief, small, section or another paragraph to the doc explaining a summary of the reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants