Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPEDGE-1346: feat: bump api to pull in arbiter node infra #14469

Merged
merged 1 commit into from
Jan 22, 2025
Merged

OCPEDGE-1346: feat: bump api to pull in arbiter node infra #14469

merged 1 commit into from
Jan 22, 2025

Conversation

eggfoobar
Copy link
Contributor

@eggfoobar eggfoobar commented Nov 5, 2024 •
edited
Loading

Per EP: openshift/enhancements#1674

This PR adds the enum for the new control plane topology value of HighlyAvailableArbiter to the list of known values during the validation step.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2024
@openshift-ci openshift-ci bot requested review from jhadvig and TheRealJon November 5, 2024 20:24
@openshift-ci openshift-ci bot added the component/backend Related to backend label Nov 5, 2024
@eggfoobar eggfoobar force-pushed the add-arbiter-node-support branch from da9caf7 to 44a4551 Compare November 5, 2024 22:15
@eggfoobar eggfoobar force-pushed the add-arbiter-node-support branch from 44a4551 to ec5d901 Compare November 18, 2024 02:49
@eggfoobar eggfoobar changed the title WIP: feat: bump api to pull in arbiter node infra WIP: OCPEDGE-1346: feat: bump api to pull in arbiter node infra Nov 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 18, 2024 •
edited by openshift-ci bot
Loading

@eggfoobar: This pull request references OCPEDGE-1346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar eggfoobar force-pushed the add-arbiter-node-support branch from ec5d901 to d45053a Compare November 18, 2024 04:14
@eggfoobar eggfoobar force-pushed the add-arbiter-node-support branch 2 times, most recently from f6271c1 to 209c3cf Compare December 11, 2024 20:16
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2024 •
edited by openshift-ci bot
Loading

@eggfoobar: This pull request references OCPEDGE-1346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Per EP: openshift/enhancements#1674

This PR adds the enum for the new control plane topology value of HighlyAvailableArbiter to the list of known values during the validation step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar eggfoobar changed the title WIP: OCPEDGE-1346: feat: bump api to pull in arbiter node infra OCPEDGE-1346: feat: bump api to pull in arbiter node infra Dec 11, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2024
jhadvig
jhadvig approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jhadvig
Copy link
Member

jhadvig commented Dec 12, 2024

/retest

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 12, 2024
@eggfoobar
Copy link
Contributor Author

/retest-required

3 similar comments
@eggfoobar
Copy link
Contributor Author

/retest-required

@eggfoobar
Copy link
Contributor Author

/retest-required

@eggfoobar
Copy link
Contributor Author

/retest-required

@eggfoobar
feat: bump api to pull in arbiter node infra
5188da1 
update validation to allow HighlyAvailableArbiter

Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar eggfoobar force-pushed the add-arbiter-node-support branch from 209c3cf to 5188da1 Compare January 8, 2025 15:40
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@eggfoobar
Copy link
Contributor Author

Hey @jhadvig I noticed the go.mod file was altering a few too many things for this PR, I updated it to use the replace stanza and keep things pointed at just the ocp/api change. Would you mind giving it another look when you have a moment.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025 •
edited
Loading

@eggfoobar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 5188da1 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jaypoulz
Copy link

/lgtm

Re-adding the LGTM label since the rebase is just bumping dependencies.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, jaypoulz, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sr1kar99
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jan 22, 2025
@Neilhamza
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 22, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2025 •
edited by openshift-ci bot
Loading

@eggfoobar: This pull request references OCPEDGE-1346 which is a valid jira issue.

In response to this:

Per EP: openshift/enhancements#1674

This PR adds the enum for the new control plane topology value of HighlyAvailableArbiter to the list of known values during the validation step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 22, 2025
@sferich888
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jan 22, 2025
@eggfoobar
Copy link
Contributor Author

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit c487437 into openshift:master Jan 22, 2025
6 of 7 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.19.0-202501222307.p0.gc487437.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@jaypoulz jaypoulz

@jhadvig jhadvig

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@eggfoobar @openshift-ci-robot @jhadvig @jaypoulz @sr1kar99 @Neilhamza @sferich888 @openshift-bot