-
Notifications
You must be signed in to change notification settings - Fork 150
NO-JIRA: Add /vendor Claude code command #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@jhadvig: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jhadvig: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Leo6Leo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is specific for the openshift/api vendor, maybe a more specific command name can be found? (e.g. /api-bump or something like this).
Or if we want to turn this /vendor command to a more generic command (i.e. can be used for any go lang dependency bump / clean up). WDYT? @jhadvig
| - Once fixed, create a brief summary of the fix nature for the commit message (store in `FIX` variable) | ||
|
|
||
| ## 8. Commit Changes | ||
| Create one or two commits depending on whether code fixes were needed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like Claude to ask for approval before perform the commit action. Since I might want to inspect the changes that Claude made before committing and pushing to GitHub.
|
|
||
| **Commit 1 - Dependency bump (always created):** | ||
| - Files: `go.mod`, `go.sum`, and `vendor/` directory | ||
| - Format: `<JIRA>: Bump openshift/api to <SHORT-SHA>` (if JIRA provided) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The format will be beneficial to specify both from to .... would be helpful for backtracing purposes.
Example would be:
<JIRA>: Bump openshift/api from <SHORT-SHA> to <SHORT-SHA>
| **Commit 1 - Dependency bump (always created):** | ||
| - Files: `go.mod`, `go.sum`, and `vendor/` directory | ||
| - Format: `<JIRA>: Bump openshift/api to <SHORT-SHA>` (if JIRA provided) | ||
| - Format: `Bump openshift/api to <SHORT-SHA>` (if no JIRA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous comment applies to here as well.
| - Format: `Bump openshift/api to <SHORT-SHA>` (if no JIRA) | ||
| - Use first 7-8 characters of SHA for SHORT-SHA | ||
|
|
||
| **Commit 2 - Code fixes (only if fixes were needed):** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I would like Claude to ask for approval before perform any commit action, so that I can manually check and go through the changes that Claude made.
Add /vendor slash command for automated PR preparation
A Claude Code slash command that automates the process of vendoring the
openshift/apirepository at a specific commit SHA.Usage
Features
CONSOLE-<number>orOCPBUGS-<number>patternsa. Dependency bump: : Bump openshift/api to
b. Code fixes (if needed): :
Workflow
Error Recovery
If the process fails, rollback with:
git reset --hard HEAD~1 # or HEAD~2if both commits were created
/assign @TheRealJon @Leo6Leo @logonoff @cajieh