Skip to content

Introduce an examine command for selective run of investigation on a cluster #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Introduce an examine command for selective run of investigation on a cluster #433

wants to merge 3 commits into from

Conversation

petrkotas
Copy link
Member

WIP

Signed-off-by: Petr Kotas pkotas@redhat.com

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petrkotas
Once this PR has been reviewed and has the lgtm label, please assign makdaam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

petrkotas added 2 commits May 6, 2025 04:20
@petrkotas
Isolate metrics and logging for investgate command
d065716 
As a preparation step for adding new commands to cadctl, this commit
moves the logging and metrics code from the root command to the
investigate command. This allows for a cleaner separation of concerns
and makes it easier to add new commands in the future.

The initial logging only bare minimum, and expands
based on the command.

Signed-off-by: Petr Kotas <pkotas@redhat.com>
@petrkotas
Adds the examine command to cadctl
19ea4af 
Introduces the `examine` command to `cadctl`,
which allows users to examine the various investigations on selected cluster.

Modifies the logging to provide human-readable output.
Modifies the investigation registry to allow for listing and
selecting an investigation by name.

Signed-off-by: Petr Kotas <pkotas@redhat.com>
@petrkotas petrkotas force-pushed the add-examine-command branch from 058e398 to 19ea4af Compare May 6, 2025 09:03
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrkotas @openshift-merge-robot