Skip to content

OPRUN-3590: Update to use api/operator/v1 OLM resource #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

OPRUN-3590: Update to use api/operator/v1 OLM resource #79

merged 1 commit into from
Nov 8, 2024

Conversation

@perdasilva
Copy link

@perdasilva perdasilva commented Nov 7, 2024

Updates openshift/api and openshift/client-go dependencies carrying the operators/v1 OLM api, and refactors cluster-olm-operator to use v1 instead of v1alpha1 OLM api

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2024 •
edited by openshift-ci bot
Loading

@perdasilva: This pull request references OPRUN-3590 which is a valid jira issue.

In response to this:

Updates openshift/api and openshift/client-go dependencies carrying the operators/v1 OLM api, and refactors cluster-olm-operator to use v1 instead of v1alpha1 OLM api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@perdasilva
Copy link
Author

perdasilva commented Nov 7, 2024

/hold ?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024
@joelanford
Copy link
Member

joelanford commented Nov 7, 2024

/lgtm

@perdasilva I'm comfortable with moving to the OLM operator v1 API before we're in the default payload. If you are good with that too, definitely feel free to remove your hold.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2024
@joelanford
Copy link
Member

joelanford commented Nov 7, 2024

/hold cancel

@perdasilva told me in slack that he's good with merging if tests pass.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2024

/retest-required

Remaining retests: 0 against base HEAD 7120e60 and 2 for PR HEAD 00c514c in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 8, 2024

/retest-required

Remaining retests: 0 against base HEAD 1df7873 and 1 for PR HEAD 00c514c in total

@perdasilva perdasilva force-pushed the perdasilva/bump/operators-api-olm-v1 branch from 00c514c to 5ee2d79 Compare November 8, 2024 14:34
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@joelanford
Copy link
Member

joelanford commented Nov 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@perdasilva perdasilva force-pushed the perdasilva/bump/operators-api-olm-v1 branch from 5ee2d79 to f8b9fd1 Compare November 8, 2024 17:23
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@perdasilva perdasilva force-pushed the perdasilva/bump/operators-api-olm-v1 branch from f8b9fd1 to e489cb7 Compare November 8, 2024 18:00
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
@openshift-merge-bot
Merge pull request openshift#77 from perdasilva/perdasilva/olm-relate…
34c3186 
…d-objects

OPRUN-3599: Add OLM resource to relatedObjects
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the perdasilva/bump/operators-api-olm-v1 branch from e489cb7 to 34c3186 Compare November 8, 2024 19:22
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
@joelanford
Copy link
Member

joelanford commented Nov 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 98328c6 into openshift:main Nov 8, 2024
5 checks passed
@openshift-bot
Copy link

openshift-bot commented Nov 9, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-olm-operator
This PR has been included in build ose-cluster-olm-operator-container-v4.18.0-202411090037.p0.g98328c6.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@joelanford joelanford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@perdasilva @openshift-ci-robot @joelanford @openshift-bot @openshift-merge-robot