Skip to content

[release-4.14] OCPBUGS-21845:rps: trigger udev event per queue #832 #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 3, 2023
Merged

[release-4.14] OCPBUGS-21845:rps: trigger udev event per queue #832 #832

merged 4 commits into from
Dec 3, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #816

/assign yanirq

Tal-or added 4 commits October 17, 2023 22:01
@Tal-or
rps: trigger udev per queue
e40263f 
Instead of trigger udev event per physical device creation,
triggers it per queue creation so in case of queue resize
(i.e. more queues are added) it applies the correct rps mask on the
new created queues as well.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
rps: simplifiy set-rps-mask.sh script
295193d 
With the new udev rule, the full path passes to the systemd unit.
Hence, we don't need jump through loops in order to figure out the
physical device location.

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
rps: do no escape instance name
f58135e 
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@Tal-or
render-sync
d417884 
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 17, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-18662 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.14] OCPBUGS-21845:rps: trigger udev even per queue

In response to this:

This is an automated cherry-pick of #816

/assign yanirq

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-18662:rps: trigger udev even per queue [release-4.14] OCPBUGS-21845:rps: trigger udev even per queue Oct 17, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 17, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-21845, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18662 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-18662 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @gsr-shanks

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #816

/assign yanirq

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gsr-shanks October 17, 2023 22:02
@Tal-or
Copy link
Contributor

Tal-or commented Oct 18, 2023

/assign Tal-or

@Tal-or
Copy link
Contributor

Tal-or commented Oct 18, 2023

/retest

1 similar comment
@Tal-or
Copy link
Contributor

Tal-or commented Oct 19, 2023

/retest

@Tal-or
Copy link
Contributor

Tal-or commented Oct 23, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@Tal-or
Copy link
Contributor

Tal-or commented Nov 2, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2023
@Tal-or
Copy link
Contributor

Tal-or commented Nov 2, 2023

/retitle [release-4.14] OCPBUGS-21845:rps: trigger udev event per queue #832

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-21845:rps: trigger udev even per queue [release-4.14] OCPBUGS-21845:rps: trigger udev event per queue #832 Nov 2, 2023
@Tal-or
Copy link
Contributor

Tal-or commented Nov 2, 2023

/cc @yanirq @mrniranjan please add the relevant labels

@openshift-ci openshift-ci bot requested review from yanirq and mrniranjan November 2, 2023 16:41
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

@Tal-or: GitHub didn't allow me to request PR reviews from the following users: please, add, the, relevant.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yanirq @mrniranjan please add the relevant labels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanirq
Copy link
Contributor

yanirq commented Nov 12, 2023

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2023
@yanirq
Copy link
Contributor

yanirq commented Nov 12, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 12, 2023
@Tal-or
Copy link
Contributor

Tal-or commented Nov 12, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2023
@shajmakh
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 13, 2023
@Tal-or
Copy link
Contributor

Tal-or commented Nov 13, 2023 •
edited
Loading

/hold
the chronological order is #831 goes first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2023
@Tal-or
Copy link
Contributor

Tal-or commented Nov 13, 2023

@yanirq @shajmakh please look at #831 as well it should go first

@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 30, 2023
Merged
@Tal-or
Copy link
Contributor

Tal-or commented Dec 3, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 3, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9c43bc1 into openshift:release-4.14 Dec 3, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-21845: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-21845 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #816

/assign yanirq

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.14.0-202312031310.p0.g9c43bc1.assembly.stream for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

@Tal-or Tal-or mentioned this pull request Dec 3, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-12-03-135752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsr-shanks gsr-shanks Awaiting requested review from gsr-shanks

@yanirq yanirq Awaiting requested review from yanirq

@mrniranjan mrniranjan Awaiting requested review from mrniranjan

Assignees

@yanirq yanirq

@Tal-or Tal-or

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @Tal-or @yanirq @shajmakh @openshift-bot @openshift-merge-robot