OCPBUGS-18662:rps: trigger udev even per queue #816
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| SUBSYSTEM=="queues", ACTION=="add", ENV{DEVPATH}=="/devices/pci*/queues/rx*", TAG+="systemd", ENV{SYSTEMD_WANTS}="update-rps@%p.service" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,16 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| path=${1} | ||
| [ -n "${path}" ] || { echo "The device path argument is missing" >&2 ; exit 1; } | ||
|
|
||
| mask=${2} | ||
| [ -n "${mask}" ] || { echo "The mask argument is missing" >&2 ; exit 1; } | ||
|
|
||
| queue_path=${path%rx*} | ||
|
|
||
| queue_num=${path#*queues/} | ||
| # replace '/' with '-' | ||
| queue_num="${queue_num/\//-}" | ||
|
There was a problem hiding this comment. minor nit: is this substitution required? If I read correctly $path is not escaped anymore and this is basically de-escaping the queue nr part Another minor note: you could possibly mention in the commit message that this change additionally avoid looping on all the rx queue, just for better future memory ;) both nits are not intended to block the MR, just to be considered if a new version should be needed for any reason There was a problem hiding this comment.
when the |
||
|
|
||
| # set rps affinity for the queue | ||
| echo "${mask}" > "/sys${queue_path}${queue_num}/rps_cpus" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| apiVersion: machineconfiguration.openshift.io/v1 | ||
| kind: KubeletConfig | ||
| metadata: | ||
| creationTimestamp: null | ||
| name: performance-manual | ||
| ownerReferences: | ||
| - apiVersion: performance.openshift.io/v2 | ||
| kind: PerformanceProfile | ||
| name: manual | ||
| uid: "" | ||
| spec: | ||
| kubeletConfig: | ||
| apiVersion: kubelet.config.k8s.io/v1beta1 | ||
| authentication: | ||
| anonymous: {} | ||
| webhook: | ||
| cacheTTL: 0s | ||
| x509: {} | ||
| authorization: | ||
| webhook: | ||
| cacheAuthorizedTTL: 0s | ||
| cacheUnauthorizedTTL: 0s | ||
| containerRuntimeEndpoint: "" | ||
| cpuManagerPolicy: static | ||
| cpuManagerPolicyOptions: | ||
| full-pcpus-only: "true" | ||
| cpuManagerReconcilePeriod: 5s | ||
| evictionHard: | ||
| imagefs.available: 15% | ||
| memory.available: 100Mi | ||
| nodefs.available: 10% | ||
| nodefs.inodesFree: 5% | ||
| evictionPressureTransitionPeriod: 0s | ||
| fileCheckFrequency: 0s | ||
| httpCheckFrequency: 0s | ||
| imageMinimumGCAge: 0s | ||
| kind: KubeletConfiguration | ||
| kubeReserved: | ||
| memory: 500Mi | ||
| logging: | ||
| flushFrequency: 0 | ||
| options: | ||
| json: | ||
| infoBufferSize: "0" | ||
| verbosity: 0 | ||
| memoryManagerPolicy: Static | ||
| memorySwap: {} | ||
| nodeStatusReportFrequency: 0s | ||
| nodeStatusUpdateFrequency: 0s | ||
| reservedMemory: | ||
| - limits: | ||
| memory: 1100Mi | ||
| numaNode: 0 | ||
| reservedSystemCPUs: "0" | ||
| runtimeRequestTimeout: 0s | ||
| shutdownGracePeriod: 0s | ||
| shutdownGracePeriodCriticalPods: 0s | ||
| streamingConnectionIdleTimeout: 0s | ||
| syncFrequency: 0s | ||
| systemReserved: | ||
| memory: 500Mi | ||
| topologyManagerPolicy: single-numa-node | ||
| volumeStatsAggPeriod: 0s | ||
| machineConfigPoolSelector: | ||
| matchLabels: | ||
| machineconfiguration.openshift.io/role: worker-cnf | ||
| status: | ||
| conditions: null |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the devpath for patching events is almost full sysfs queue directory - just missing the '/sys' prefix...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK the path should start from
/devicesand not from/systhis is how it worked so far.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tal-or: I was not clear in the sentence above, I'm sorry. What I mean is that since the devpath for patching events is almost full sysfs queue directory, we can exploit such fact to simplify the action, as hopefully better described in my comment on set-rps-mask.sh.
The above sentence and the comment there are supposed to be read one after another as part of a the same message