OCPBUGS-18662: e2e:rps: improve logging #787
Conversation
print the expected rps mask for physical and virtual network devices. This change would help with debugging the test in case of failure. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
|
/retest |
Tal-or
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@Tal-or: This pull request references Jira Issue OCPBUGS-18662, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Printing the rps masks in case of failure is more readable then printing the cpuset. this is because an empty mask i.e 0000 is interpeted as an empty cpuset i.e "" (empty quotes) Signed-off-by: Talor Itzhak <titzhak@redhat.com>
In case the test failed, we asserts only the desired and actual mask, but we are not specifing the device on which the RPS mask was bad. This patch adds the full device path as part of the error message. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
Tal-or
force-pushed
the
rps_test_improve_logging
branch
from
8d4bddb to
1e37c03
Compare
|
@Tal-or: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Tal-or, yanirq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@Tal-or: Jira Issue OCPBUGS-18662: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-18662 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This bump is for debug purposes. We improve the logging in the RPS test openshift/cluster-node-tuning-operator#787 (comment) in order to find out why the test failed upstream. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
|
Fix included in accepted release 4.15.0-0.nightly-2023-10-17-065657 |
|
/cherry-pick release-4.14 |
|
@yanirq: new pull request created: #831 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR not intended to fix the flakiness we have but should help
with finding the the culprit virtual device which causes it.