OCPBUGS-18052: feat: added logic to handle legacy sno install #778
Conversation
openshift-ci-robot
added
jira/severity-critical
|
@eggfoobar: This pull request references Jira Issue OCPBUGS-18052, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold Validating fix |
openshift-ci
bot
added
the
do-not-merge/hold
updated documentation to correctly refer to feature as 4.14 changed variables to be more consistent with current naming pattern Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
ocpbugs-18052-workload-pinning
branch
from
521971e to
f82e9dc
Compare
|
/unhold Verified that the fix worked with a build from cluster bot. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, yanirq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@yanirq: This pull request references Jira Issue OCPBUGS-18052, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
thanks @eggfoobar , makes sense to me. The only gap I see is that we should improve the testing side
Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
Signed-off-by: ehila <ehila@redhat.com>
|
@eggfoobar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@eggfoobar Thank you for the PR and the added e2e tests. |
|
@eggfoobar: Jira Issue OCPBUGS-18052: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-18052 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When openshift#778 got merged The directory layout has changed and broke the `render-sync` make target. This patch should fix it. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
When #778 got merged The directory layout has changed and broke the `render-sync` make target. This patch should fix it. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
When openshift#778 got merged The directory layout has changed and broke the `render-sync` make target. This patch should fix it. Signed-off-by: Talor Itzhak <titzhak@redhat.com>
When #778 got merged The directory layout has changed and broke the `render-sync` make target. This patch should fix it. Signed-off-by: Talor Itzhak <titzhak@redhat.com> Co-authored-by: Talor Itzhak <titzhak@redhat.com>
added legacy check method to generate MCs for SNO installs using the old MC method
updated documentation to correctly refer to feature as 4.14