E2E: Granular IRQ functional test cases #1441
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oblau The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
oblau
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| }) | ||
|
|
||
| It("checks that houskeeping takes first cpu from cpu's asigned to container", func() { | ||
| getHousekeepingCpus := []string{"printenv", "OPENSHIFT_HOUSEKEEPING_CPUS"} |
There was a problem hiding this comment.
Is the duplication of the env var check necessary?
There was a problem hiding this comment.
I would remove the simpler test above and keep just this one.
this pr adds testcases related to granular irq affinity control feature test cases are related to testing new pod annotation: irq-load-balancing.crio.io: "housekeeping" added another test case related to multiple containers Signed-off-by: oblau <oblau@redhat.com>
| }) | ||
|
|
||
| It("verifies each container has OPENSHIFT_HOUSEKEEPING_CPUS aligned with its first CPU siblings", func() { | ||
| // Get core sibling topology once |
There was a problem hiding this comment.
The code duplication will make this hard to maintain. Why not make this code a function and call it for both single and two container per pod cases?
|
Testing the env var is fine, but what I am missing the most is the check of the IRQ affinity. Because that is the real effect of the feature. The irq affinity / irqbalance configuration must contain the housekeeping cpus and NOT contain the rest of the cpus the container has. |
Using describe table insted of It blocks Utilizing funcitons for better redability Signed-off-by: oblau <oblau@redhat.com>
|
@oblau: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
this pr adds testcases related to granular irq affinity control feature test cases are related to testing new pod annotation: irq-load-balancing.crio.io: "housekeeping"