fix: updated initializations and tests

updated controller initializations to pass down clock param for testing
updated tests results to be in lexical order and timestamp to reflect test.yaml

Signed-off-by: ehila <ehila@redhat.com>

Author: eggfoobar

pkg/cmd/operator/cmd.go

@@ -2,7 +2,6 @@ package operator
 
 import (
 	"github.com/spf13/cobra"
-
 	"k8s.io/utils/clock"
 
 	"github.com/openshift/cluster-authentication-operator/pkg/operator"

pkg/operator/replacement_starter.go

@@ -7,6 +7,7 @@ import (
 	"time"
 
 	kubeinformers "k8s.io/client-go/informers"
+	"k8s.io/utils/clock"
 
 	kubemigratorclient "sigs.k8s.io/kube-storage-version-migrator/pkg/clients/clientset"
 	migrationv1alpha1informer "sigs.k8s.io/kube-storage-version-migrator/pkg/clients/informer"
@@ -51,6 +52,7 @@ type authenticationOperatorInput struct {
 	apiregistrationv1Client      apiregistrationclient.Interface
 	migrationClient              kubemigratorclient.Interface
 	eventRecorder                events.Recorder
+	clock                        clock.PassiveClock
 
 	informerFactories []libraryapplyconfiguration.SimplifiedInformerFactory
 }
@@ -129,6 +131,7 @@ func CreateOperatorInputFromMOM(ctx context.Context, momInput libraryapplyconfig
 		apiregistrationv1Client:      apiregistrationv1Client,
 		migrationClient:              migrationClient,
 		eventRecorder:                eventRecorder,
+		clock:                        momInput.Clock,
 		informerFactories: []libraryapplyconfiguration.SimplifiedInformerFactory{
 			libraryapplyconfiguration.DynamicInformerFactoryAdapter(dynamicInformers), // we don't share the dynamic informers, but we only want to start when requested
 		},
@@ -199,6 +202,7 @@ func CreateControllerInputFromControllerContext(ctx context.Context, controllerC
 		apiregistrationv1Client:      apiregistrationv1Client,
 		migrationClient:              migrationClient,
 		eventRecorder:                eventRecorder,
+		clock:                        clock.RealClock{},
 		informerFactories: []libraryapplyconfiguration.SimplifiedInformerFactory{
 			libraryapplyconfiguration.DynamicInformerFactoryAdapter(dynamicInformers), // we don't share the dynamic informers, but we only want to start when requested
 		},

pkg/operator/starter.go

@@ -435,6 +435,7 @@ func prepareOauthAPIServerOperator(
 		"oauth-apiserver",
 		authOperatorInput.authenticationOperatorClient,
 		eventRecorder,
+		authOperatorInput.clock,
 	).WithWorkloadController(
 		"OAuthAPIServerController",
 		"openshift-authentication-operator",

test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/ApplyStatus/cluster-scoped-resources/operator.openshift.io/authentications/4dff-body-cluster.yaml

@@ -6,8 +6,8 @@ status:
   conditions:
   - lastTransitionTime: "2024-10-14T22:38:20Z"
     message: |-
-      endpoints/host-etcd-2 in the openshift-etcd namespace: not found
       configmap openshift-etcd/etcd-endpoints not found, and fallback observer failed
+      endpoints/host-etcd-2 in the openshift-etcd namespace: not found
       oauth.config.openshift.io "cluster" not found
     reason: Error
     status: "True"

test-data/apply-configuration/overall/minimal-cluster/expected-output/Management/UpdateStatus/cluster-scoped-resources/config.openshift.io/clusteroperators/0598-body-authentication.yaml

@@ -6,23 +6,23 @@ metadata:
 spec: {}
 status:
   conditions:
-  - lastTransitionTime: "2024-12-05T18:54:45Z"
+  - lastTransitionTime: "2024-10-14T22:38:20Z"
     reason: NoData
     status: Unknown
     type: Degraded
-  - lastTransitionTime: "2024-12-05T18:54:45Z"
+  - lastTransitionTime: "2024-10-14T22:38:20Z"
     reason: NoData
     status: Unknown
     type: Progressing
-  - lastTransitionTime: "2024-12-05T18:54:45Z"
+  - lastTransitionTime: "2024-10-14T22:38:20Z"
     reason: NoData
     status: Unknown
     type: Available
-  - lastTransitionTime: "2024-12-05T18:54:45Z"
+  - lastTransitionTime: "2024-10-14T22:38:20Z"
     reason: NoData
     status: Unknown
     type: Upgradeable
-  - lastTransitionTime: "2024-12-05T18:54:45Z"
+  - lastTransitionTime: "2024-10-14T22:38:20Z"
     reason: NoData
     status: Unknown
     type: EvaluationConditionsDetected

test-data/apply-configuration/overall/minimal-cluster/expected-output/controller-results.yaml

@@ -55,8 +55,8 @@ controllerResults:
 - controllerName: TODO-other-configObserver
   errors:
   - message: |-
-      endpoints/host-etcd-2 in the openshift-etcd namespace: not found
       configmap openshift-etcd/etcd-endpoints not found, and fallback observer failed
+      endpoints/host-etcd-2 in the openshift-etcd namespace: not found
       oauth.config.openshift.io "cluster" not found
   status: Failed
 - controllerName: TODO-payloadConfigController