MGMT-14838: Upgrade go modules #81
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@CrystalChun: This pull request references MGMT-14838 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| RunSpecsWithDefaultAndCustomReporters(t, | ||
| "Controller Suite", | ||
| []Reporter{printer.NewlineReporter{}}) | ||
| RunSpecs(t, "Controller Suite") |
There was a problem hiding this comment.
For history: the envtest/printer was removed from the controller-runtime repo in kubernetes-sigs/controller-runtime#1977
Following what others have done: csi-addons/kubernetes-csi-addons@74c24b3
openshift-ci
bot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CrystalChun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
https://issues.redhat.com/browse/MGMT-14838 In preparation to switch APIs from v1alpha1 to v1beta1.
CrystalChun
force-pushed
the
upgrade-packages
branch
from
8e511a3
to
b1a8556
Compare
https://issues.redhat.com/browse/MGMT-14838 There were a few changes to controller-runtime such as the Cache BuilderWithOptions function and Source.Kind being removed.
CrystalChun
force-pushed
the
upgrade-packages
branch
from
b1a8556
to
1b5d830
Compare
|
@CrystalChun: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing for now |
https://issues.redhat.com/browse/MGMT-14838
In preparation to switch APIs from v1alpha1
to v1beta1.
/cc @eranco74 @filanov