Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-19236: Add Openshift sandboxed containers operator(OSC) support #2579

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

pezhang
Copy link
Contributor

@pezhang pezhang commented Nov 28, 2024

  • Testing with 3 masters and 3 workers, the osc operator can be installed.
    Screenshot from 2024-12-02 23-32-30

  • Testing with SNO, the osc operator can be installed.
    Screenshot from 2024-12-03 10-27-37

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2024
Copy link

openshift-ci bot commented Nov 28, 2024

Hi @pezhang. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pezhang
Copy link
Contributor Author

pezhang commented Nov 28, 2024

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

Copy link

openshift-ci bot commented Nov 28, 2024

@pezhang: pezhang unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to this:

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 2, 2024
@eifrach
Copy link
Contributor

eifrach commented Dec 2, 2024

/ok-to-test
/lgtm

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@pezhang
Copy link
Contributor Author

pezhang commented Dec 3, 2024

/retest

@pezhang
Copy link
Contributor Author

pezhang commented Dec 3, 2024

Hello @eifrach Could you help to review this patch again? Thanks a lot.

@eifrach
Copy link
Contributor

eifrach commented Dec 3, 2024

/test e2e-metal-assisted-kube-api-late-binding-single-node

@eifrach
Copy link
Contributor

eifrach commented Dec 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
@pezhang
Copy link
Contributor Author

pezhang commented Dec 4, 2024

/retest

@eifrach
Copy link
Contributor

eifrach commented Dec 4, 2024

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

@eifrach
Copy link
Contributor

eifrach commented Dec 4, 2024

/approve

@eifrach
Copy link
Contributor

eifrach commented Dec 4, 2024

/retitle MGMT-19236: Add Openshift sandboxed containers operator(OSC) support

@openshift-ci openshift-ci bot changed the title Add Openshift sandboxed containers operator(OSC) support MGMT-19236: Add Openshift sandboxed containers operator(OSC) support Dec 4, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 4, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2024

@pezhang: This pull request references MGMT-19236 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

  • Testing with 3 masters and 3 workers, the osc operator can be installed.
    Screenshot from 2024-12-02 23-32-30

  • Testing with SNO, the osc operator can be installed.
    Screenshot from 2024-12-03 10-27-37

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach, pezhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2024
Copy link

openshift-ci bot commented Dec 4, 2024

@eifrach: Overrode contexts on behalf of eifrach: ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

In response to this:

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@eifrach
Copy link
Contributor

eifrach commented Dec 4, 2024

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

Copy link

openshift-ci bot commented Dec 4, 2024

@eifrach: Overrode contexts on behalf of eifrach: ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

In response to this:

/override ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Dec 4, 2024

@pezhang: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d908249 into openshift:master Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants