Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-4990 - fix pep8 linter issues #1177

Merged
merged 1 commit into from
Oct 21, 2021
Merged

MGMT-4990 - fix pep8 linter issues #1177

merged 1 commit into from
Oct 21, 2021

Conversation

eliorerz
Copy link
Contributor

No description provided.

@eliorerz
Copy link
Contributor Author

/cc @tsorya @osherdp

@openshift-ci openshift-ci bot requested review from osherdp and tsorya October 20, 2021 12:22
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 20, 2021
@eliorerz eliorerz force-pushed the MGMT-4990-Fix_PEP8_linter_issues branch from 6b63a5b to 95ba6c0 Compare October 20, 2021 12:24
@tsorya
Copy link
Contributor

tsorya commented Oct 20, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@eliorerz
Copy link
Contributor Author

/override ci/prow/lint

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2021

@eliorerz: Overrode contexts on behalf of eliorerz: ci/prow/lint

In response to this:

/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eliorerz
Copy link
Contributor Author

/test ?

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2021

@eliorerz: The following commands are available to trigger required jobs:

  • /test e2e-metal-assisted
  • /test e2e-metal-assisted-kube-api
  • /test images
  • /test lint

The following commands are available to trigger optional jobs:

  • /test e2e-metal-assisted-ipv4v6
  • /test e2e-metal-assisted-ipv6
  • /test e2e-metal-assisted-kube-api-late-binding-single-node
  • /test e2e-metal-assisted-multi-version
  • /test e2e-metal-assisted-networking
  • /test e2e-metal-assisted-none
  • /test e2e-metal-assisted-none-ipv6
  • /test e2e-metal-assisted-olm
  • /test e2e-metal-assisted-single-node
  • /test e2e-metal-single-node-live-iso
  • /test system-test-operator

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api
  • pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-late-binding-single-node
  • pull-ci-openshift-assisted-test-infra-master-images
  • pull-ci-openshift-assisted-test-infra-master-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eliorerz
Copy link
Contributor Author

/test lint

@eliorerz
Copy link
Contributor Author

/retest

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@eliorerz eliorerz force-pushed the MGMT-4990-Fix_PEP8_linter_issues branch from 95ba6c0 to 83c6166 Compare October 20, 2021 13:42
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021
@eliorerz
Copy link
Contributor Author

/override ci/prow/lint

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2021

@eliorerz: Overrode contexts on behalf of eliorerz: ci/prow/lint

In response to this:

/override ci/prow/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eliorerz eliorerz force-pushed the MGMT-4990-Fix_PEP8_linter_issues branch from 83c6166 to e32baeb Compare October 20, 2021 21:56
@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 20, 2021
@eliorerz eliorerz mentioned this pull request Oct 21, 2021
Merged
@eliorerz eliorerz force-pushed the MGMT-4990-Fix_PEP8_linter_issues branch from e32baeb to 65186a2 Compare October 21, 2021 07:01
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2021
osherdp
osherdp suggested changes Oct 21, 2021
View reviewed changes
discovery-infra/test_infra/assisted_service_api.py
cluster = self.cluster_get(cluster_id=cluster_id)
self.cluster_get(cluster_id=cluster_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then why do we do that?
did we wanted to return it at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using it.. I think we can just delete it

discovery-infra/test_infra/controllers/nat_controller.py Outdated Show resolved Hide resolved
discovery-infra/test_infra/controllers/node_controllers/libvirt_controller.py Outdated Show resolved Hide resolved
discovery-infra/test_infra/controllers/node_controllers/libvirt_controller.py Outdated Show resolved Hide resolved
@eliorerz eliorerz changed the title Mgmt 4990 fix pep8 linter issues WIP - Mgmt 4990 fix pep8 linter issues Oct 21, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2021
@eliorerz eliorerz force-pushed the MGMT-4990-Fix_PEP8_linter_issues branch from 65186a2 to 805de2a Compare October 21, 2021 07:29
@eliorerz eliorerz force-pushed the MGMT-4990-Fix_PEP8_linter_issues branch from 805de2a to d7b2d95 Compare October 21, 2021 07:39
osherdp
osherdp approved these changes Oct 21, 2021
View reviewed changes
discovery-infra/test_infra/controllers/nat_controller.py
def __init__(self, input_interfaces: Union[List, Tuple], ns_index: Union[str, int]):
self._input_interfaces = input_interfaces
self._ns_index = ns_index
self._mark = self._build_mark()

def add_nat_rules(self) -> None:
"""" Add rules for the input interfaces and output interfaces """
""" Add rules for the input interfaces and output interfaces """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove whitespaces

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eliorerz eliorerz changed the title WIP - Mgmt 4990 fix pep8 linter issues MGMT-4990 - fix pep8 linter issues Oct 21, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@eliorerz eliorerz mentioned this pull request Oct 21, 2021
Merged
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@eliorerz
Copy link
Contributor Author

/override ci/prow/e2e-metal-assisted-olm
/override ci/prow/e2e-metal-assisted-ipv4v6
/override ci/prow/e2e-metal-assisted-networking

@openshift-merge-robot openshift-merge-robot merged commit 81084fd into openshift:master Oct 21, 2021
@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2021

@eliorerz: Overrode contexts on behalf of eliorerz: ci/prow/e2e-metal-assisted-ipv4v6, ci/prow/e2e-metal-assisted-networking, ci/prow/e2e-metal-assisted-olm

In response to this:

/override ci/prow/e2e-metal-assisted-olm
/override ci/prow/e2e-metal-assisted-ipv4v6
/override ci/prow/e2e-metal-assisted-networking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eliorerz eliorerz deleted the MGMT-4990-Fix_PEP8_linter_issues branch April 10, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osherdp osherdp osherdp approved these changes

@tsorya tsorya Awaiting requested review from tsorya

Assignees

@osherdp osherdp

@tsorya tsorya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eliorerz @tsorya @openshift-bot @osherdp @openshift-merge-robot