Skip to content

machineconfiguration: add dropInDir details for KubeletConfigSpec #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreibytes
Copy link

No description provided.

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
Signed-off-by: andrei <lizardcoder6@gmail.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2025
@andreibytes
Copy link
Author

/test all

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 1, 2025
Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andreibytes
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

Hello @andreibytes! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 1, 2025
Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

Hi @andreibytes. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

@andreibytes: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@QiWang19
Copy link
Member

QiWang19 commented Jul 1, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 1, 2025
Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

@andreibytes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview-1of2 ffeff33 link true /test e2e-aws-serial-techpreview-1of2
ci/prow/e2e-upgrade-out-of-change ffeff33 link true /test e2e-upgrade-out-of-change
ci/prow/lint ffeff33 link true /test lint
ci/prow/minor-e2e-upgrade-minor ffeff33 link true /test minor-e2e-upgrade-minor
ci/prow/verify-crd-schema ffeff33 link true /test verify-crd-schema
ci/prow/e2e-aws-ovn-hypershift ffeff33 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial-techpreview-2of2 ffeff33 link true /test e2e-aws-serial-techpreview-2of2
ci/prow/images ffeff33 link true /test images
ci/prow/build ffeff33 link true /test build
ci/prow/e2e-aws-ovn-hypershift-conformance ffeff33 link true /test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-aws-serial-1of2 ffeff33 link true /test e2e-aws-serial-1of2
ci/prow/e2e-aws-ovn-techpreview ffeff33 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn ffeff33 link true /test e2e-aws-ovn
ci/prow/e2e-upgrade ffeff33 link true /test e2e-upgrade
ci/prow/e2e-aws-serial-2of2 ffeff33 link true /test e2e-aws-serial-2of2
ci/prow/unit ffeff33 link true /test unit
ci/prow/e2e-azure ffeff33 link false /test e2e-azure
ci/prow/okd-scos-e2e-aws-ovn ffeff33 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants