OCPBUGS-44324 : Rename files to use the default run-level for storage #2105
Conversation
|
Hello @bertinatto! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XS
|
You may re-number as you wish, but I think the default is 80, so moving 50 to 80 is probably bad. |
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
Makes sense to me, since the other *csi* manifests are in the default run-level 50
$ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release:4.18.0-ec.3-x86_64
$ ls manifests/*csi* | sort
manifests/0000_50_cluster-csi-snapshot-controller-operator_01_config.crd.yaml
manifests/0000_50_cluster-csi-snapshot-controller-operator_02_operator_cr.yaml
...
manifests/0000_50_cluster-csi-snapshot-controller-operator_10_clusteroperator.yaml
manifests/0000_50_cluster-storage-operator_02_csi_driver_operators_namespace.yaml
...
manifests/0000_50_cluster-storage-operator_09_openshift-csi-resizer-storageclass-reader-role.yaml
manifests/0000_90_csi-driver_01_clustercsidrivers.crd.yamlAlthough I'm not sure which of those would be trying to interact with the ClusterCSIDriver API.
|
/lgtm |
openshift-ci
bot
added
approved
bertinatto
force-pushed
the
decrease-runlevel-clustercsidrivers
branch
from
931ca42 to
cb82e6c
Compare
openshift-ci
bot
added
size/L
bertinatto
force-pushed
the
decrease-runlevel-clustercsidrivers
branch
from
05e974f to
1ed01cd
Compare
There was a problem hiding this comment.
weird that this is a new file, not a move.
There was a problem hiding this comment.
interesting, the script just added a new file
There was a problem hiding this comment.
seems like a bug in the script. I'll add to my queue, but I'm not sure when I'll be able to get to it (CC @JoelSpeed )
There was a problem hiding this comment.
pushed a commit to clean the CRDs directory before cloning the CRDs into it. PTAL
openshift-ci
bot
added
size/S
This helps when a runlevel for a CRD is changed. In that case, the old CRD should be deleted.
bertinatto
force-pushed
the
decrease-runlevel-clustercsidrivers
branch
from
4bf9b38 to
15f5718
Compare
|
@bertinatto: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Looks better now, schema checker error is not fixable /lgtm Does this need the ack critical fixes label? |
|
@JoelSpeed: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, deads2k, JoelSpeed, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adding the label, as this can fix an issue that has been blocking the Storage team: /label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/override ci/prow/verify-crd-schema |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This indeed appears to fix the issue. I made a build from this PR and upgraded from 4.17 and operator logs appeared to be calm. |
openshift-merge-bot
bot
merged commit ec9bf3f
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
Need the changes in openshift/api#2105
|
/jira refresh |
8 participants
This ensures that CRD updates are applied earlier during a cluster upgrade process. This prevents CSI operators from accessing new/updated fields of the CR before the corresponding CRDs been updated.
CC @openshift/storage